[tests] Dot shorthands: Update bad language tests.

Updating some `??` tests to make them emit the correct warnings.
Removed an expected error where there wasn't one.

Bug: #59835
Change-Id: I8a1282e01ece6f3fd776eb06bcbb2cd7a1f8ed2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425587
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

tests/language/dot_shorthands/constructor/constructor_if_null_error_test.dart

@@ -8,44 +8,52 @@
 
 import '../dot_shorthand_helper.dart';
 
+extension type IfNullConstructorExt(int x) implements num {
+  IfNullConstructorExt.regular(this.x);
+  IfNullConstructorExt.named({this.x = 1});
+  IfNullConstructorExt.optional([this.x = 1]);
+}
+
 void constructorClassTest() {
   ConstructorClass ctor = ConstructorClass(1);
 
   // Warning when LHS is not able to be `null`.
   ConstructorClass notNullable = .new(1) ?? ctor;
-  // ^
-  // [analyzer] unspecified
+  //                                        ^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 
   ConstructorClass notNullableRegular = .regular(1) ?? ctor;
-  // ^
-  // [analyzer] unspecified
+  //                                                   ^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 
   ConstructorClass notNullableNamed = .named(x: 1) ?? ctor;
-  // ^
-  // [analyzer] unspecified
+  //                                                  ^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 
   ConstructorClass notNullableOptional = .optional(1) ?? ctor;
-  // ^
-  // [analyzer] unspecified
+  //                                                     ^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 }
 
 void constructorExtTest() {
-  ConstructorExt ctorExt = ConstructorExt(1);
+  IfNullConstructorExt ctorExt = IfNullConstructorExt(1);
 
   // Warning when LHS is not able to be `null`.
-  ConstructorExt notNullableExt = .new(1) ?? ctorExt;
-  // ^
-  // [analyzer] unspecified
-
-  ConstructorExt notNullableRegularExt = .regular(1) ?? ctorExt;
-  // ^
-  // [analyzer] unspecified
-
-  ConstructorExt notNullableNamedExt = .named(x: 1) ?? ctorExt;
-  // ^
-  // [analyzer] unspecified
+  IfNullConstructorExt notNullableExt = .new(1) ?? ctorExt;
+  //                                               ^^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+  IfNullConstructorExt notNullableRegularExt = .regular(1) ?? ctorExt;
+  //                                                          ^^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+  IfNullConstructorExt notNullableNamedExt = .named(x: 1) ?? ctorExt;
+  //                                                         ^^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+  IfNullConstructorExt notNullableOptionalExt = .optional(1) ?? ctorExt;
+  //                                                            ^^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+}
 
-  ConstructorExt notNullableOptionalExt = .optional(1) ?? ctorExt;
-  // ^
-  // [analyzer] unspecified
+void main() {
+  constructorClassTest();
+  constructorExtTest();
 }

tests/language/dot_shorthands/member/static_method_if_null_error_test.dart

@@ -8,28 +8,37 @@
 
 import '../dot_shorthand_helper.dart';
 
+extension type IfNullExt<T extends num>(T x) implements num {
+  static IfNullExt<int> member() => IfNullExt(1);
+  static IfNullExt<U> memberType<U extends num, V>(U u) => IfNullExt(u);
+}
+
 void memberTest() {
   StaticMember member = StaticMember.member();
 
   // Warning when LHS is not able to be `null`.
   StaticMember memberLocal = .member() ?? member;
-  // ^
-  // [analyzer] unspecified
+  //                                      ^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 
   StaticMember memberType = .memberType<String, int>("s") ?? member;
-  // ^
-  // [analyzer] unspecified
+  //                                                         ^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
 }
 
 void memberExtTest() {
-  StaticMemberExt<int> member = StaticMemberExt.member();
+  IfNullExt<int> member = IfNullExt.member();
 
   // Warning when LHS is not able to be `null`.
-  StaticMemberExt memberLocal = .member() ?? member;
-  // ^
-  // [analyzer] unspecified
+  IfNullExt memberLocal = .member() ?? member;
+  //                                   ^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+  IfNullExt memberType = .memberType<int, String>(1) ?? member;
+  //                                                    ^^^^^^
+  // [analyzer] STATIC_WARNING.DEAD_NULL_AWARE_EXPRESSION
+}
 
-  StaticMemberExt memberType = .memberType<String, int>("s") ?? member;
-  // ^
-  // [analyzer] unspecified
+void main() {
+  memberTest();
+  memberExtTest();
 }

tests/language/dot_shorthands/no_context/simple_identifier_no_context_error_test.dart

@@ -65,11 +65,6 @@ void main() async {
   // [analyzer] unspecified
   // [cfe] unspecified
 
-  map[.blue] = Color.red;
-  // ^
-  // [analyzer] unspecified
-  // [cfe] unspecified
-
   // Null assert.
   .one!;
   // ^