[kernel] Scope calculator filters out wildcard variables

Fixes #60841.

Change-Id: Id1fd9300ad241af879ca7dfff3e4bf61125af852
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433720
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

Author: jensjoha

pkg/kernel/lib/dart_scope_calculator.dart

@@ -160,7 +160,9 @@ class DartScopeBuilder extends VisitorDefault<void> with VisitorVoidMixin {
     //
     // A null name signals that the variable was synthetically introduced by the
     // compiler so they are skipped.
-    if ((decl.fileOffset < 0 || decl.fileOffset < _offset) && name != null) {
+    if ((decl.fileOffset < 0 || decl.fileOffset < _offset) &&
+        !decl.isWildcard &&
+        name != null) {
       _definitions[name] = decl.type;
     }
     super.visitVariableDeclaration(decl);
@@ -289,7 +291,8 @@ class DartScopeBuilder2 extends VisitorDefault<void> with VisitorVoidMixin {
         String? name = decl.name;
         if (name != null &&
             !decl.isSynthesized &&
-            !hoistedUnwritten.contains(decl)) {
+            !hoistedUnwritten.contains(decl) &&
+            !decl.isWildcard) {
           definitions[name] = decl;
         }
       }

pkg/kernel/test/dart_scope_calculator_test.dart

@@ -360,6 +360,9 @@ class ScopeTestingBinaryPrinter extends BinaryPrinter {
           if (variable.isHoisted && !setVariables.contains(variable)) {
             // A hoisted variable that isn't set (yet) --- pretend it isn't
             // there.
+          } else if (variable.isWildcard) {
+            // A wildcard variable doesn't really exist so we'll ignore it,
+            // see https://github.com/dart-lang/sdk/issues/60841.
           } else {
             expectedVariablesMap[name] = variable.type;
           }