Skip to content

Conversation

davidmorgan
Copy link
Contributor

This change is mostly by @stereotype441 with a few tweaks on top by me :) ... it passes tests in google3.

This makes source_gen comply with the lint, except for one line where I add an ignore to continue calling generateForAnnotatedElement.

After this I think the next steps are:

  1. migrate all users in google3 to source_gen element2 API
  2. next source_gen PR: copy element2 methods removing the "2" to give the final API we want, but leaving the APIs with "2" in the name in place
  3. migrate all users in google3 to source_gen renamed element2->element API
  4. next+1 source_gen PR: remove all methods with "2" in the name

how does that sound? Thanks :)

@davidmorgan davidmorgan requested review from kevmoo and scheglov March 31, 2025 15:53
@davidmorgan davidmorgan merged commit 44cc7a8 into dart-lang:analyzer-element2 Apr 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants