Skip to content

Handle null library in _NameTypeChecker. #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

Handle null library in _NameTypeChecker. #791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b600b0
Handle null library in _NameTypeChecker.
davidmorgan Oct 2, 2025
4f11600
Add a test.
davidmorgan Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source_gen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 4.0.2-wip

- Bug fix: fix possible null pointer exception in `TypeChecker.typeNamed` on
invalid code.

## 4.0.1

- Require `analyzer: '>=8.1.1 <9.0.0'`.
Expand Down
4 changes: 3 additions & 1 deletion source_gen/lib/src/type_checker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,9 @@ class _NameTypeChecker extends TypeChecker {

@override
bool isExactly(Element element) {
final uri = element.library!.uri;
final library = element.library;
if (library == null) return false;
final uri = library.uri;
return element.name == _typeName &&
(_inPackage == null ||
(((uri.scheme == 'dart') == _inSdk) &&
Expand Down
2 changes: 1 addition & 1 deletion source_gen/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: source_gen
version: 4.0.1
version: 4.0.2-wip
description: >-
Source code generation builders and utilities for the Dart build system
repository: https://github.com/dart-lang/source_gen/tree/master/source_gen
Expand Down