-
Notifications
You must be signed in to change notification settings - Fork 220
Add --suite-load-timeout
option
#2505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add --suite-load-timeout
option
#2505
Conversation
@natebosch I need a bit of feedback here. Would be a If you are not the right person for this, could you tag someone else? After this, I will add tests for this PR 👍 |
/// The timeout for loading a test suite. | ||
final Timeout? _suiteLoadTimeout; | ||
Timeout get suiteLoadTimeout => | ||
_suiteLoadTimeout ?? const Timeout(Duration(minutes: 12)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented --suite-load-timeout
the same way as --ignore-timeouts
was implemented. However, it's not optimal that we have two locations for the default value. Here and in pkgs/test_core/lib/src/runner/configuration/args.dart
. Should we improve this? Or not? Or just writing a comment to update the default value also in the other file?
I'm marking this as ready for review in the hope of getting some feedback. |
I think it would be fine to add a |
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
--suite-load-timeout
option--suite-load-timeout
option
This PR adds a
--suite-load-timeout
argument to remove the hard-coded timeout (see #2463). [More description is added later]Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.