Get version from a hard coded value instead of the pubspec.lock

pkgs/test/CHANGELOG.md

@@ -4,6 +4,8 @@
 * Require Dart 3.7
 * Add `--coverage-path` and `--branch-coverage` options to `dart test`.
 * Serve dart2wasm source map files.
+* Change `--version` to use a hard coded value instead of reading it from the
+  pubspec.lock, this is more efficient and supports workspaces.
 
 ## 1.26.3
 

pkgs/test/lib/src/executable.dart

@@ -9,6 +9,7 @@ import 'package:test_core/src/runner/hack_register_platform.dart'; // ignore: im
 
 import 'runner/browser/platform.dart';
 import 'runner/node/platform.dart';
+import 'version.dart';
 
 Future<void> main(List<String> args) async {
   registerPlatformPlugin([Runtime.nodeJS], NodePlatform.new);
@@ -19,5 +20,5 @@ Future<void> main(List<String> args) async {
     Runtime.safari,
   ], BrowserPlatform.start);
 
-  await executable.main(args);
+  await executable.main(args, testVersion: testVersion);
 }

pkgs/test/lib/src/version.dart

@@ -0,0 +1,9 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// The version of the `test` package.
+///
+/// Must match what is in the pubspec.yaml, and enforced by
+/// test/version_test.dart.
+const String testVersion = '1.27.0-wip';

pkgs/test/pubspec.yaml

@@ -47,6 +47,7 @@ dependencies:
 dev_dependencies:
   fake_async: ^1.0.0
   glob: ^2.0.0
+  pubspec_parse: ^1.2.0
   test_descriptor: ^2.0.0
   test_process: ^2.0.0
 

pkgs/test/test/runner/json_reporter_utils.dart

@@ -5,8 +5,8 @@
 import 'dart:convert';
 
 import 'package:path/path.dart' as p;
+import 'package:test/src/version.dart';
 import 'package:test/test.dart';
-import 'package:test_core/src/runner/version.dart';
 import 'package:test_descriptor/test_descriptor.dart' as d;
 
 /// Asserts that the outputs from running tests with a JSON reporter match the

pkgs/test/test/version_test.dart

@@ -0,0 +1,20 @@
+// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+@TestOn('vm')
+library;
+
+import 'dart:io';
+
+import 'package:pubspec_parse/pubspec_parse.dart';
+import 'package:test/src/version.dart';
+import 'package:test/test.dart';
+
+void main() {
+  test('testVersion is up to date', () {
+    final file = File('pubspec.yaml');
+    final pubspec = Pubspec.parse(file.readAsStringSync(), sourceUrl: file.uri);
+    expect(pubspec.version.toString(), testVersion);
+  });
+}

pkgs/test_core/CHANGELOG.md

@@ -3,6 +3,8 @@
 * Restrict to latest version of analyzer package.
 * Require Dart 3.7
 * Add `--coverage-path` and `--branch-coverage` options to `dart test`.
+* Change `--version` to use a hard coded value instead of reading it from the
+  pubspec.lock, this is more efficient and supports workspaces.
 
 ## 0.6.12
 

pkgs/test_core/lib/src/executable.dart

@@ -15,7 +15,6 @@ import 'runner.dart';
 import 'runner/application_exception.dart';
 import 'runner/configuration.dart';
 import 'runner/no_tests_found_exception.dart';
-import 'runner/version.dart';
 import 'util/errors.dart';
 import 'util/exit_codes.dart' as exit_codes;
 import 'util/io.dart';
@@ -34,8 +33,10 @@ final String _globalConfigPath = () {
   }
 }();
 
-Future<void> main(List<String> args) async {
-  await _execute(args);
+/// Main entrypoint for the executable, the [version] is the version of the
+/// test runner executing this function.
+Future<void> main(List<String> args, {String? testVersion}) async {
+  await _execute(args, testVersion: testVersion);
   completeShutdown();
 }
 
@@ -54,7 +55,7 @@ void completeShutdown() {
   cancelStdinLines();
 }
 
-Future<void> _execute(List<String> args) async {
+Future<void> _execute(List<String> args, {String? testVersion}) async {
   /// A merged stream of all signals that tell the test runner to shut down
   /// gracefully.
   ///
@@ -87,12 +88,11 @@ Future<void> _execute(List<String> args) async {
   }
 
   if (configuration.version) {
-    var version = testVersion;
-    if (version == null) {
+    if (testVersion == null) {
       stderr.writeln("Couldn't find version number.");
       exitCode = exit_codes.data;
     } else {
-      print(version);
+      print(testVersion);
     }
     return;
   }
@@ -157,7 +157,7 @@ Future<void> _execute(List<String> args) async {
   });
 
   try {
-    runner = Runner(configuration);
+    runner = Runner(configuration, testVersion: testVersion);
     exitCode = (await runner.run()) ? 0 : 1;
   } on ApplicationException catch (error) {
     stderr.writeln(error.message);

pkgs/test_core/lib/src/runner.dart

@@ -72,35 +72,40 @@ class Runner {
   /// Sinks created for each file reporter (if there are any).
   final List<IOSink> _sinks;
 
-  /// Creates a new runner based on [configuration].
-  factory Runner(Configuration config) => config.asCurrent(() {
-    var engine = Engine(
-      concurrency: config.concurrency,
-      coverage: config.coverage,
-      coverageLcov: config.coverageLcov,
-      testRandomizeOrderingSeed: config.testRandomizeOrderingSeed,
-      stopOnFirstFailure: config.stopOnFirstFailure,
-    );
+  /// Creates a new runner based on [config].
+  ///
+  /// The [testVersion] is the test runner version.
+  factory Runner(Configuration config, {String? testVersion}) =>
+      config.asCurrent(() {
+        var engine = Engine(
+          concurrency: config.concurrency,
+          coverage: config.coverage,
+          coverageLcov: config.coverageLcov,
+          testRandomizeOrderingSeed: config.testRandomizeOrderingSeed,
+          stopOnFirstFailure: config.stopOnFirstFailure,
+          testVersion: testVersion,
+        );
 
-    var sinks = <IOSink>[];
-    Reporter createFileReporter(String reporterName, String filepath) {
-      final sink = (File(filepath)..createSync(recursive: true)).openWrite();
-      sinks.add(sink);
-      return allReporters[reporterName]!.factory(config, engine, sink);
-    }
+        var sinks = <IOSink>[];
+        Reporter createFileReporter(String reporterName, String filepath) {
+          final sink =
+              (File(filepath)..createSync(recursive: true)).openWrite();
+          sinks.add(sink);
+          return allReporters[reporterName]!.factory(config, engine, sink);
+        }
 
-    return Runner._(
-      engine,
-      MultiplexReporter([
-        // Standard reporter.
-        allReporters[config.reporter]!.factory(config, engine, stdout),
-        // File reporters.
-        for (var reporter in config.fileReporters.keys)
-          createFileReporter(reporter, config.fileReporters[reporter]!),
-      ]),
-      sinks,
-    );
-  });
+        return Runner._(
+          engine,
+          MultiplexReporter([
+            // Standard reporter.
+            allReporters[config.reporter]!.factory(config, engine, stdout),
+            // File reporters.
+            for (var reporter in config.fileReporters.keys)
+              createFileReporter(reporter, config.fileReporters[reporter]!),
+          ]),
+          sinks,
+        );
+      });
 
   Runner._(this._engine, this._reporter, this._sinks);
 

pkgs/test_core/lib/src/runner/configuration/reporters.dart

@@ -33,7 +33,7 @@ final UnmodifiableMapView<String, ReporterDetails> allReporters =
 final _allReporters = <String, ReporterDetails>{
   'compact': ReporterDetails(
     'A single line, updated continuously.',
-    (config, engine, sink) => CompactReporter.watch(
+    (config, engine, sink, {version}) => CompactReporter.watch(
       engine,
       sink,
       color: config.color,
@@ -47,7 +47,7 @@ final _allReporters = <String, ReporterDetails>{
   ),
   'expanded': ReporterDetails(
     'A separate line for each update.',
-    (config, engine, sink) => ExpandedReporter.watch(
+    (config, engine, sink, {version}) => ExpandedReporter.watch(
       engine,
       sink,
       color: config.color,
@@ -61,7 +61,7 @@ final _allReporters = <String, ReporterDetails>{
   ),
   'failures-only': ReporterDetails(
     'A separate line for failing tests with no output for passing tests',
-    (config, engine, sink) => FailuresOnlyReporter.watch(
+    (config, engine, sink, {version}) => FailuresOnlyReporter.watch(
       engine,
       sink,
       color: config.color,
@@ -76,7 +76,7 @@ final _allReporters = <String, ReporterDetails>{
   'github': ReporterDetails(
     'A custom reporter for GitHub Actions '
     '(the default reporter when running on GitHub Actions).',
-    (config, engine, sink) => GithubReporter.watch(
+    (config, engine, sink, {version}) => GithubReporter.watch(
       engine,
       sink,
       printPath:
@@ -90,13 +90,13 @@ final _allReporters = <String, ReporterDetails>{
   'json': ReporterDetails(
     'A machine-readable format (see '
     'https://dart.dev/go/test-docs/json_reporter.md).',
-    (config, engine, sink) =>
+    (config, engine, sink, {version}) =>
         JsonReporter.watch(engine, sink, isDebugRun: config.debug),
   ),
   'silent': ReporterDetails(
     'A reporter with no output. '
     'May be useful when only the exit code is meaningful.',
-    (config, engine, sink) => SilentReporter(),
+    (config, engine, sink, {version}) => SilentReporter(),
   ),
 };
 

pkgs/test_core/lib/src/runner/engine.dart

@@ -205,6 +205,11 @@ class Engine {
   /// `false` to `true`.
   Stream get onIdle => _group.onIdle;
 
+  /// The version of the test reporter (generally, the `test` package).
+  ///
+  /// Can be `null` if not running using the test runner.
+  final String? testVersion;
+
   /// Creates an [Engine] that will run all tests provided via [suiteSink].
   ///
   /// [concurrency] controls how many suites are loaded and ran at once, and
@@ -218,13 +223,14 @@ class Engine {
   /// [coverage] specifies a directory to output coverage information.
   ///
   /// If [stopOnFirstFailure] then a single failing test will cause the engine
-  /// to [close] and stop ruunning further tests.
+  /// to [close] and stop running further tests.
   Engine({
     int? concurrency,
     String? coverage,
     String? coverageLcov,
     this.testRandomizeOrderingSeed,
     bool stopOnFirstFailure = false,
+    this.testVersion,
   }) : _runPool = Pool(concurrency ?? 1),
        _stopOnFirstFailure = stopOnFirstFailure,
        _coverage = coverage,

pkgs/test_core/lib/src/runner/reporter/json.dart

@@ -22,7 +22,6 @@ import '../../platform.dart';
 import '../engine.dart';
 import '../load_suite.dart';
 import '../reporter.dart';
-import '../version.dart';
 
 /// A reporter that prints machine-readable JSON-formatted test results.
 class JsonReporter implements Reporter {
@@ -89,7 +88,7 @@ class JsonReporter implements Reporter {
 
     _emit('start', {
       'protocolVersion': '0.1.1',
-      'runnerVersion': testVersion,
+      'runnerVersion': _engine.testVersion,
       'pid': pid,
     });
   }