Skip to content

Allow exceptions from operator == #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow exceptions from operator == #2543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/matcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

* Add `isSorted` and related matchers for iterables.
* Consider `NaN` to be equal to itself in `equals`.
* Allow exceptions from `operator ==` to bubble up and fail the test instead of
treating them as unequal objects.
* Remove some dynamic invocations.
* Add explicit casts from `dynamic` values.
* Require Dart 3.7
Expand Down
22 changes: 6 additions & 16 deletions pkgs/matcher/lib/src/equals_matcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,22 +210,12 @@ class _DeepMatcher extends Matcher {
});
} else {
// Otherwise, test for equality, or both values NaN
try {
if (expected == actual ||
(expected is num &&
expected.isNaN &&
actual is num &&
actual.isNaN)) {
return null;
}
} catch (e) {
// TODO(gram): Add a test for this case.
return _Mismatch(
location,
actual,
(description, verbose) =>
description.add('== threw ').addDescriptionOf(e),
);
if (expected == actual ||
(expected is num &&
expected.isNaN &&
actual is num &&
actual.isNaN)) {
return null;
}
}

Expand Down
Loading