[matcher] Add type check in pairwiseCompare#2596
Merged
Conversation
Closes #2454 Currently a failure from the cast causes a failure output including: Which: has <null> which is not <null> at index null Fill in the missing info by adding an explicit type check instead of an unchecked cast before passing to the comparison callback. Elements with mismatched type are treated identically to those which fail the comparison, but should be clear to a reader of the failure.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
brianquinlan
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2454
Currently a failure from the cast causes a failure output including:
Fill in the missing info by adding an explicit type check instead of an
unchecked cast before passing to the comparison callback. Elements with
mismatched type are treated identically to those which fail the
comparison, but should be clear to a reader of the failure.