Fix hang when separate-process test crashes#2606
Merged
Conversation
Fixes #2577 If the child process used for the `--compiler exe` mode crashes it might not close the socket use for test runner communication. Close the socket from the server side during the platform closure to avoid a process hang.
natebosch
changed the title
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
During cleanup this socket is no longer useful so it's safe to destroy. Using destroy over close prevents an exception when the socket was already closed by the remote side in the typical case where the sub-process does not crash early.
Test times out without the fix
jakemac53
approved these changes
Mar 9, 2026
natebosch
added a commit
to rmacnak-google/test
that referenced
this pull request
Mar 9, 2026
Should no longer hang following dart-lang#2606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2577
If the child process used for the
--compiler exemode crashes it mightnot close the socket use for test runner communication. Destroy the
socket from the server side during the platform closure to avoid a
process hang.