[package:mime] make mp3 default for audio/mpeg#2048
Open
fstotz wants to merge 3 commits intodart-lang:mainfrom
Open
[package:mime] make mp3 default for audio/mpeg#2048fstotz wants to merge 3 commits intodart-lang:mainfrom
fstotz wants to merge 3 commits intodart-lang:mainfrom
Conversation
Contributor
|
Hi @fstotz, thanks for the contribution! Re: changing the default extension for mpeg - we're considering updating this package to use another canonical mapping (Apache httpd?), and then having few if any diffs from that mapping. If we thought a mapping needed to be updated, people could either update the new system-of-record, or have local changes for their project, but for the most part we wouldn't change this project. See also #2028. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2043
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.