Skip to content

Commit f5c5e83

Browse files
committed
Fix trailing commas.
1 parent c1f39ef commit f5c5e83

20 files changed

+41
-42
lines changed

dwds/analysis_options.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ analyzer:
1010
linter:
1111
rules:
1212
- always_use_package_imports
13-
- require_trailing_commas

dwds/lib/src/services/chrome_proxy_service.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class ChromeProxyService implements VmServiceInterface {
224224
// Expression evaluation is ready after dependencies are updated.
225225
if (!_compilerCompleter.isCompleted) _compilerCompleter.complete();
226226
return result;
227-
}, (result) => DwdsEvent.compilerUpdateDependencies(entrypoint),);
227+
}, (result) => DwdsEvent.compilerUpdateDependencies(entrypoint));
228228
}
229229
}
230230

@@ -683,7 +683,7 @@ class ChromeProxyService implements VmServiceInterface {
683683
RPCErrorKind.kInvalidRequest.code,
684684
'Expression evaluation is not supported for this configuration.',
685685
);
686-
}, (result) => DwdsEvent.evaluate(expression, result),);
686+
}, (result) => DwdsEvent.evaluate(expression, result));
687687
}
688688

689689
String _newVariableForScope(Map<String, String>? scope) {
@@ -744,7 +744,7 @@ class ChromeProxyService implements VmServiceInterface {
744744
RPCErrorKind.kInvalidRequest.code,
745745
'Expression evaluation is not supported for this configuration.',
746746
);
747-
}, (result) => DwdsEvent.evaluateInFrame(expression, result),);
747+
}, (result) => DwdsEvent.evaluateInFrame(expression, result));
748748
}
749749

750750
@override
@@ -796,7 +796,7 @@ class ChromeProxyService implements VmServiceInterface {
796796
await isInitialized;
797797
_checkIsolate('getIsolate', isolateId);
798798
return inspector.isolate;
799-
}, (result) => DwdsEvent.getIsolate(),);
799+
}, (result) => DwdsEvent.getIsolate());
800800
}
801801

802802
@override
@@ -848,7 +848,7 @@ class ChromeProxyService implements VmServiceInterface {
848848
await isInitialized;
849849
_checkIsolate('getScripts', isolateId);
850850
return inspector.getScripts();
851-
}, (result) => DwdsEvent.getScripts(),);
851+
}, (result) => DwdsEvent.getScripts());
852852
}
853853

854854
@override
@@ -900,7 +900,7 @@ class ChromeProxyService implements VmServiceInterface {
900900
reportLines: reportLines,
901901
libraryFilters: libraryFilters,
902902
);
903-
}, (result) => DwdsEvent.getSourceReport(),);
903+
}, (result) => DwdsEvent.getSourceReport());
904904
}
905905

906906
/// Returns the current stack.
@@ -936,7 +936,7 @@ class ChromeProxyService implements VmServiceInterface {
936936
return captureElapsedTime(() async {
937937
await isInitialized;
938938
return _vm;
939-
}, (result) => DwdsEvent.getVM(),);
939+
}, (result) => DwdsEvent.getVM());
940940
}
941941

942942
@override
@@ -1159,7 +1159,7 @@ class ChromeProxyService implements VmServiceInterface {
11591159
step: step,
11601160
frameIndex: frameIndex,
11611161
);
1162-
}, (result) => DwdsEvent.resume(step),);
1162+
}, (result) => DwdsEvent.resume(step));
11631163
} else {
11641164
inspector.appConnection.runMain();
11651165
return Success();

dwds/lib/src/utilities/server.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ void serveHttpRequests(
6868
) {
6969
return Chain.capture(() {
7070
serveRequests(requests, handler);
71-
}, onError: onError,);
71+
}, onError: onError);
7272
}
7373

7474
/// Throws an [wip.ExceptionDetails] object if `exceptionDetails` is present on the
@@ -96,7 +96,7 @@ Map<String, dynamic> getResultOrHandleError(
9696
if (result == null) {
9797
throw ChromeDebugException({
9898
'text': 'null result from Chrome Devtools',
99-
}, evalContents: evalContents,);
99+
}, evalContents: evalContents);
100100
}
101101
return result;
102102
}

dwds/lib/src/utilities/shared.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ Future<T> wrapInErrorHandlerAsync<T>(
4444
'Unexpected DWDS error for $command: $error',
4545
),
4646
);
47-
}, test: (e) => e is! RPCError && e is! SentinelException,);
47+
}, test: (e) => e is! RPCError && e is! SentinelException);
4848
}

dwds/test/common/chrome_proxy_service_common.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1462,7 +1462,7 @@ void runTests({
14621462

14631463
final sourceReport = await service.getSourceReport(isolateId, [
14641464
'PossibleBreakpoints',
1465-
], scriptId: mainScript.id,);
1465+
], scriptId: mainScript.id);
14661466

14671467
expect(sourceReport.scripts, isNotEmpty);
14681468
expect(sourceReport.ranges, isNotEmpty);

dwds/test/devtools_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void main() {
5454
expect(await context.webDriver.pageSource, contains('DevTools'));
5555
expect(await context.webDriver.currentUrl, contains('ide=Dwds'));
5656
// TODO(https://github.com/dart-lang/webdev/issues/1888): Re-enable.
57-
}, skip: Platform.isWindows,);
57+
}, skip: Platform.isWindows);
5858

5959
test(
6060
'can not launch devtools for the same app in multiple tabs',
@@ -140,7 +140,7 @@ void main() {
140140
},
141141
skip: 'https://github.com/dart-lang/webdev/issues/1888',
142142
);
143-
}, timeout: Timeout.factor(2),);
143+
}, timeout: Timeout.factor(2));
144144

145145
group('Injected client without a DevTools server', () {
146146
setUp(() async {

dwds/test/evaluate_common.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ void testAll({
612612
matchErrorRef(contains(EvaluationErrorKind.loadModule)),
613613
);
614614
});
615-
}, skip: 'https://github.com/dart-lang/sdk/issues/48587',);
615+
}, skip: 'https://github.com/dart-lang/sdk/issues/48587');
616616

617617
test('cannot evaluate in unsupported isolate', () async {
618618
await onBreakPoint(mainScript, 'printLocal', (event) async {
@@ -795,7 +795,7 @@ void testAll({
795795
expect(result, matchInstanceRef('42'));
796796
});
797797
});
798-
}, timeout: const Timeout.factor(2),);
798+
}, timeout: const Timeout.factor(2));
799799

800800
group('shared context with no evaluation |', () {
801801
setUpAll(() async {

dwds/test/events_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ void main() {
164164
'elapsedMilliseconds': isNotNull,
165165
'screen': equals('debugger'),
166166
}),
167-
], () => keyboard.sendChord([Keyboard.alt, 'd']),);
167+
], () => keyboard.sendChord([Keyboard.alt, 'd']));
168168
},
169169
skip: 'https://github.com/dart-lang/webdev/issues/2394',
170170
);
@@ -380,7 +380,7 @@ void main() {
380380
}),
381381
() => service.getSourceReport(isolateId, [
382382
SourceReportKind.kPossibleBreakpoints,
383-
], scriptId: mainScript.id,),
383+
], scriptId: mainScript.id),
384384
);
385385
});
386386
});

dwds/test/fixtures/context.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class TestContext {
209209
await Process.run(sdkLayout.dartPath, [
210210
'pub',
211211
'upgrade',
212-
], workingDirectory: project.absolutePackageDirectory,);
212+
], workingDirectory: project.absolutePackageDirectory);
213213

214214
ExpressionCompiler? expressionCompiler;
215215
AssetReader assetReader;

dwds/test/fixtures/project.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class TestProject {
156156
'run',
157157
'build_runner',
158158
'clean',
159-
], workingDirectory: absolutePackageDirectory,);
159+
], workingDirectory: absolutePackageDirectory);
160160
}
161161

162162
/// The path to the Dart specified file in the 'lib' directory, e.g,

0 commit comments

Comments
 (0)