Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Spawn DDS in a separate process using `dart development-service` instead of launching from `package:dds`. - [#2466](https://github.com/dart-lang/webdev/pull/2466)
- Update package `web_socket_channel: '>=2.2.0 <4.0.0'`.
- Require Dart `^3.4`
- Prepare to update `package:vm_service_interface` constraint to `2.0.0`.

## 24.0.0

Expand Down
41 changes: 36 additions & 5 deletions dwds/lib/src/services/chrome_proxy_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Map<String, String>? scope,
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.evaluate].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'evaluate',
Expand Down Expand Up @@ -716,6 +721,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Map<String, String>? scope,
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.evaluateInFrame].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'evaluateInFrame',
Expand Down Expand Up @@ -805,6 +815,7 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
int limit, {
bool? includeImplementers,
bool? includeSubclasses,
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getInstances');
}
Expand Down Expand Up @@ -845,6 +856,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
String objectId, {
int? offset,
int? count,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.getObject].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'getObject',
Expand Down Expand Up @@ -946,7 +962,15 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
///
/// The returned stack will contain up to [limit] frames if provided.
@override
Future<Stack> getStack(String isolateId, {int? limit}) =>
Future<Stack> getStack(
String isolateId, {
int? limit,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.getStack].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'getStack',
() => _getStack(isolateId, limit: limit),
Expand Down Expand Up @@ -1002,6 +1026,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
List argumentIds, {
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.invoke].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'invoke',
Expand Down Expand Up @@ -1591,17 +1620,19 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Future<InboundReferences> getInboundReferences(
String isolateId,
String targetId,
int limit,
) {
int limit, {
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getInboundReferences');
}

@override
Future<RetainingPath> getRetainingPath(
String isolateId,
String targetId,
int limit,
) {
int limit, {
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getRetainingPath');
}

Expand Down
Loading