Skip to content

replace deprecated __proto__ from js code #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2024
Merged

replace deprecated __proto__ from js code #2500

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf72af3
replace deprecated __proto__ from js code
jyameo Oct 1, 2024
b86c2be
updated changelog
jyameo Oct 1, 2024
87662d7
Update dwds/lib/src/debugging/inspector.dart
jyameo Oct 1, 2024
ec72979
Update dwds/CHANGELOG.md
jyameo Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## 24.2.0-wip
- Replace deprecated JS code - [#2500](https://github.com/dart-lang/webdev/pull/2500)

## 24.1.0

Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/debugging/inspector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class AppInspector implements AppInspectorInterface {
// We use the JS pseudo-variable 'arguments' to get the list of all arguments.
final send = '''
function () {
if (!(this.__proto__)) { return 'Instance of PlainJavaScriptObject';}
if (!(Object.getPrototypeOf(this))) { return 'Instance of PlainJavaScriptObject';}
return ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").dart.dsendRepl(this, "$methodName", arguments);
}
''';
Expand Down