Add option to not use module name in MetadataProvider #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDC library bundle format does not provide module names as part of the ModuleMetadata. - To support this discrepancy, a flag is added to MetadataProvider to either use the module name or the module path to identify the module. - createProvider is added so LoadStrategys can create MetadataProviders based on whether the module format uses the module name. - Cleans up some getters and methods in LoadStrategy implementations so that getters are grouped together.
nshahan
approved these changes
Nov 27, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDC library bundle format does not provide module names as part of the ModuleMetadata.