Skip to content

[dwds] Remove reassemble extension invocation for restarter #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[dwds] Remove reassemble extension invocation for restarter #2585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions dwds/lib/src/injected/client.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions dwds/web/reloader/ddc_library_bundle_restarter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@ extension type _Debugger._(JSObject _) implements JSObject {
await invokeExtension(method, '{}').toDart;
}
}

Future<void> maybeInvokeFlutterReassemble() async {
final method = 'ext.flutter.reassemble';
if (extensionNames.toDart.contains(method.toJS)) {
await invokeExtension(method, '{}').toDart;
}
}
}

@JS('XMLHttpRequest')
Expand Down Expand Up @@ -105,9 +98,5 @@ class DdcLibraryBundleRestarter implements Restarter {
}
}
await _dartDevEmbedder.hotReload(filesToLoad, librariesToReload).toDart;
// TODO(srujzs): Reassembling is slow. It's roughly almost the time it takes
// to recompile and do a hot reload. We should do some better profiling and
// see if we can improve this.
await _dartDevEmbedder.debugger.maybeInvokeFlutterReassemble();
}
}
Loading