Skip to content

Update e2e_test expectation to look for more consistent message. #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Update e2e_test expectation to look for more consistent message. #2630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions webdev/test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ void main() {
final process = await testRunner.runWebDev(args,
workingDirectory: soundExampleDirectory);

await checkProcessStdout(process, ['Succeeded']);
await checkProcessStdout(process, ['Writing asset manifest completed']);
await process.shouldExit(0);
},
// https://github.com/dart-lang/webdev/issues/2489,
Expand All @@ -133,7 +133,7 @@ void main() {
final process = await testRunner.runWebDev(args,
workingDirectory: soundExampleDirectory);

final expectedItems = <Object>['Succeeded'];
final expectedItems = <Object>['Writing asset manifest completed'];

await checkProcessStdout(process, expectedItems);
await process.shouldExit(0);
Expand Down Expand Up @@ -166,7 +166,7 @@ void main() {
final process = await testRunner.runWebDev(args,
workingDirectory: soundExampleDirectory);

final expectedItems = <Object>['Succeeded'];
final expectedItems = <Object>['Writing asset manifest completed'];

await checkProcessStdout(process, expectedItems);
await process.shouldExit(0);
Expand All @@ -189,7 +189,9 @@ void main() {
final process = await testRunner.runWebDev(args,
workingDirectory: soundExampleDirectory);

final expectedItems = <Object>['Succeeded'];
final expectedItems = <Object>[
'Caching finalized dependency graph completed'
];

await checkProcessStdout(process, expectedItems);
await process.shouldExit(0);
Expand All @@ -215,7 +217,10 @@ void main() {
final hostUrl = 'http://localhost:$openPort';

// Wait for the initial build to finish.
await expectLater(process.stdout, emitsThrough(contains('Succeeded')));
await expectLater(
process.stdout,
emitsThrough(
contains('Caching finalized dependency graph completed')));

final client = HttpClient();

Expand Down
Loading