Skip to content

Wait for any remaining output in e2e_test.dart #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Wait for any remaining output in e2e_test.dart #2663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38f9b8
Wait for any remaining output in e2e_test.dart
nshahan Aug 4, 2025
705d073
Merge branch 'main' into fix-e2e-test
nshahan Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions webdev/test/e2e_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
@Timeout(Duration(minutes: 5))
library;

import 'dart:async';
import 'dart:io';

import 'package:io/io.dart';
Expand Down Expand Up @@ -209,8 +210,12 @@ void main() {
args.add('--release');
}

final stdoutDone = Completer<void>();
final stderrDone = Completer<void>();
final process = await testRunner.runWebDev(args,
workingDirectory: exampleDirectory);
process.stdoutStream().listen((_) => {}, onDone: stdoutDone.complete);
process.stderrStream().listen((_) => {}, onDone: stderrDone.complete);

final hostUrl = 'http://localhost:$openPort';

Expand Down Expand Up @@ -238,6 +243,7 @@ void main() {

await process.kill();
await process.shouldExit();
await Future.wait([stdoutDone.future, stderrDone.future]);
});
}
});
Expand Down
Loading