Skip to content

[dwds] Pass reloaded sources path in all hot restart calls in client #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

[dwds] Pass reloaded sources path in all hot restart calls in client #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557e431
[dwds] Pass reloaded sources path in all hot restart calls in client
srujzs Aug 21, 2025
8eee99a
Merge remote-tracking branch 'upstream/main' into passreloadedsources
srujzs Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dwds/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 25.0.3

### Bug Fixes:

- Fix issue in hot restart with the web socket where we didn't pass the reloaded
sources path, resulting in a null assertion.

## 25.0.2

### Bug Fixes:
Expand Down
11 changes: 4 additions & 7 deletions dwds/lib/src/injected/client.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 25.0.2
version: 25.0.3

description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
Expand Down
9 changes: 7 additions & 2 deletions dwds/web/client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ Future<void>? main() {
manager.reloadPage();
} else if (reloadConfiguration ==
'ReloadConfiguration.hotRestart') {
await manager.hotRestart();
await manager.hotRestart(
reloadedSourcesPath: hotRestartReloadedSourcesPath,
);
} else if (reloadConfiguration == 'ReloadConfiguration.hotReload') {
await manager.hotReloadStart(hotReloadReloadedSourcesPath);
await manager.hotReloadEnd();
Expand Down Expand Up @@ -493,7 +495,10 @@ Future<void> handleWebSocketHotRestartRequest(
final requestId = event.id;
try {
final runId = const Uuid().v4().toString();
await manager.hotRestart(runId: runId);
await manager.hotRestart(
runId: runId,
reloadedSourcesPath: hotRestartReloadedSourcesPath,
);
_sendHotRestartResponse(clientSink, requestId, success: true);
} catch (e) {
_sendHotRestartResponse(
Expand Down
Loading