Allow webdev to be run from an executable (for 'dart install') #2690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 'dart install' feature runs the installed package as an executable binary. So
Platform.resolvedExecutable
refers to the location of that prebuiltwebdev
binary rather than thedart
binary.Instead we need to lookup the path to the
dart
(ordart.exe
for windows) in the environment'sPATH
. We use the system appropriate command to query this path.See #2689 for more context.