Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 26.1.0-wip

- `pause` now does not send a `PauseInterrupted` event in
`WebSocketProxyService` as we didn't actually pause.

## 26.0.0

- Bump SDK constraint to ^3.10.0
Expand Down
18 changes: 2 additions & 16 deletions dwds/lib/src/services/web_socket_proxy_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -940,22 +940,8 @@ class WebSocketProxyService extends ProxyService {
/// Pauses execution of the isolate.
@override
Future<Success> pause(String isolateId) =>
wrapInErrorHandlerAsync('pause', () => _pause(isolateId));

Future<Success> _pause(String _) async {
// Create a pause event and store it
if (_isolateRef != null) {
final pauseEvent = vm_service.Event(
kind: vm_service.EventKind.kPauseInterrupted,
timestamp: DateTime.now().millisecondsSinceEpoch,
isolate: _isolateRef!,
);
_currentPauseEvent = pauseEvent;
_streamNotify(vm_service.EventStreams.kDebug, pauseEvent);
}

return Success();
}
// Can't pause with the web socket implementation, so do nothing.
Future.value(Success());

/// Resumes execution of the isolate.
@override
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dwds/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: dwds
# Every time this changes you need to run `dart run build_runner build`.
version: 26.0.0
version: 26.1.0-wip

description: >-
A service that proxies between the Chrome debug protocol and the Dart VM
Expand Down