refactor(dsp-api): Replace Pekko HTTP server with zio-http (DEV-4870) #3798
+2,058
−2,995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/replace-pekko-http-with-zio-http-2
seakayone
requested review from
BalduinLandolt,
mpro7 and
siers
as code owners
BalduinLandolt
approved these changes
Oct 13, 2025
| ): Task[Response[Either[String, A]]] = | ||
| addAuthIfNeeded(user, request).flatMap { req => | ||
| req | ||
| // .copy(options = req.options.copy(readTimeout = 5.seconds.asScala)) |
There was a problem hiding this comment.
I suppose this can be removed?
Comment on lines
54
to
56
| def json(): ULayer[Unit] = Runtime.removeDefaultLoggers >>> jsonLogger >+> Slf4jBridge.initialize | ||
|
|
||
| val text: ULayer[Unit] = Runtime.removeDefaultLoggers >>> textLogger >+> Slf4jBridge.initialize |
There was a problem hiding this comment.
I'm assuming json() can be deleted too, right? I think the only way a logger is ever picked, is through fromEnv().
siers
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.