ci: add rudimentary CI check for WorkloadAllowlists #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
6 times, most recently
from
78ae7d5 to
eb70da3
Compare
Member
Author
|
The check fails if the WorkloadAllowlist does not match our workload anymore: https://github.com/dash0hq/dash0-operator/actions/runs/19151058124/job/54741125962 
|
|
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
12 times, most recently
from
48d591e to
8515a03
Compare
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
from
8515a03 to
8fc557a
Compare
This check fails if the Dash0 operator workloads are changed in a way that make an update of the related WorkloadAllowlists necessary. The script currently does not check with every possible combination of Helm settings, but only checks a typical installation, including using the target-allocator. There might be cases that we miss. Testing every possible combination seems excessive at the moment. The check is currently after the release. Running it with a pre-release before actually releasing it officially would be an obvious improvement, but is out of scope for now.
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
from
8fc557a to
420cc97
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check fails if the Dash0 operator workloads are changed in a way
that make an update of the related WorkloadAllowlists necessary.
The script currently does not check with every possible combination of
Helm settings, but only checks a typical installation, including using
the target-allocator. There might be cases that we miss. Testing every
possible combination seems excessive at the moment.
The check is currently after the release. Running it with a pre-release
before actually releasing it officially would be an obvious improvement,
but is out of scope for now.