Skip to content

fix: only warn for Node.js versions >= 25.x #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

fix: only warn for Node.js versions >= 25.x #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
- '22.x'
- '23.x'
- '24.x'
# Maintenance note: Update the semver expression `untestedVersionRange` in src/index.ts when adding new
# Node.js versions to the test matrix.

steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 4 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ const versionMapping = [
// OpenTelemetry JS SDK 2.x, supports Node.js >= 18.19.0 || >= 20.6.0
['>=18.19.0', './2.x/init'],
];
const untestedVersionRange = '>=24.0.0';

// Maintenance note: This needs to be kept in sync with the version ranges in .github/workflows/verify.yaml, property
// jobs.verify.strategy.matrix.node-version.
const untestedVersionRange = '>=25.0.0';

const prefix = 'Dash0 OpenTelemetry Distribution';

Expand Down