-
Notifications
You must be signed in to change notification settings - Fork 25
Recipes in OTelBin #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Recipes in OTelBin #209
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
| title: 'Foo' | ||
| author: 'Bar' | ||
| description: 'Hello World' | ||
| config: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should use a similar markup as in supported-distributions.json to optionally allow-list distributions and version ranges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH though I would love for us to have a recipe first that is not supported by all distros :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a fair share of ADOT's wouldn't.
Also, any use of the debug exporter breaks 0.85.0 (or so) and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the difference between the invalid state generated right now and an excluded range from the perspective of the user? Maybe I am missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nice to have: tags on recipes could be super useful as the number of possible recipes grows so it's easy to filter, for example, by anything related to "aws" or "mysql", etc
|
Kudos, SonarCloud Quality Gate passed!
|
d081797 to
da8dbd9
Compare








Based on feedback here https://cloud-native.slack.com/archives/C061WC8RQJX/p1700504305991389