Skip to content

doc: fix getPrivateKey() example (missing async, typo of bytes) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

doc: fix getPrivateKey() example (missing async, typo of bytes) #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83175c6
doc: fix getPrivateKey() example (missing async, typo of bytes)
coolaj86 Aug 14, 2024
d492ce2
doc: correct misuse of tx.inputs.sort(Tx.sortInputs)
coolaj86 Aug 14, 2024
1906118
chore(release): bump to v0.18.3
coolaj86 Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,13 @@ toPublicKey(privKeyBytes)
```js
let keyUtils = {
getPrivateKey: async function (txInput, i) {
let opts = { version: "mainnet" };
let pkhBytes = DashKeys.utils.hexToBytes(txInput.pubKeyHash);
let address = await DashKeys.pkhToAddr(txInput.pubKeyHash);
let address = await DashKeys.pkhToAddr(pkhBytes, opts);

let yourKeyData = yourWalletKeyMapGoesHere[address];

let privKeyBytes = DashKeys.wifToPrivKey(yourKeyData.wif);
let privKeyBytes = await DashKeys.wifToPrivKey(yourKeyData.wif, opts);
return privKeyBytes;
},

Expand Down Expand Up @@ -490,8 +491,8 @@ Tx.createLegacyTx(coins, outputs, changeOutput);
* - `txDraft.change.address` MUST be set before signing the transaction
*
* BIP-69 Secure Sorting must be done AFTER setting each `address`
* - `Tx.sortInputs(txDraft.inputs)`
* - `Tx.sortOutputs(txDraft.outputs)`
* - `txDraft.inputs.sort(Tx.sortInputs)`
* - `txDraft.outputs.sort(Tx.sortOutputs)`
*/
let txDraft = tx.legacy.draftSingleOutput({ utxos, inputs, output });

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dashtx",
"version": "0.18.2",
"version": "0.18.3",
"description": "Create DASH Transactions with Vanilla JS (0 deps, cross-platform)",
"main": "dashtx.js",
"module": "dashtx.mjs",
Expand Down
Loading