Skip to content

fix: allow user-defined sequence and null sighashtype #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025
Merged

fix: allow user-defined sequence and null sighashtype #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c5816
fix: allow user-defined sequence and null sighashtype
coolaj86 Feb 16, 2025
545126d
chore(release): bump to v0.20.3
coolaj86 Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions dashtx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ var DashTx = ("object" === typeof module && exports) || {};
tx.push(rawScript);
}

let sequence = "ffffffff";
let sequence = input.sequence ?? "ffffffff";
tx.push(sequence);

return tx;
Expand Down Expand Up @@ -2086,6 +2086,7 @@ if ("object" === typeof module) {
* @prop {String} [script] - the previous lock script (default: derived from public key as p2pkh)
* @prop {String} publicKey - hex-encoded public key (typically starts with a 0x02 or 0x03 prefix)
* @prop {String} [pubKeyHash] - the 20-byte pubKeyHash (address without magic byte or checksum)
* @prop {String} [sequence] - the 4-byte sequence (typically ffffffff)
* @prop {Uint32} sigHashType - typically 0x81 (SIGHASH_ALL|SIGHASH_ANYONECANPAY)
*/

Expand All @@ -2100,6 +2101,7 @@ if ("object" === typeof module) {
* @prop {String} [script] - the previous lock script (default: derived from public key as p2pkh)
* @prop {String} [publicKey] - hex-encoded public key (typically starts with a 0x02 or 0x03 prefix)
* @prop {String} [pubKeyHash] - the 20-byte pubKeyHash (address without magic byte or checksum)
* @prop {String} [sequence] - the 4-byte sequence (typically ffffffff)
* @prop {Uint32} sigHashType - typically 0x81 (SIGHASH_ALL|SIGHASH_ANYONECANPAY)
*/

Expand All @@ -2110,6 +2112,7 @@ if ("object" === typeof module) {
* @prop {String} [txId] - deprecated
* @prop {String} txid - hex (not pre-reversed)
* @prop {Uint32} outputIndex - index in previous tx's output (vout index)
* @prop {String} [sequence] - the 4-byte sequence (typically ffffffff)
*/

/**
Expand All @@ -2134,7 +2137,7 @@ if ("object" === typeof module) {
*/

/**
* @typedef {Pick<TxInput, "txId"|"txid"|"outputIndex"|"signature"|"publicKey"|"sigHashType">} TxInputSigned
* @typedef {Pick<TxInput, "txId"|"txid"|"outputIndex"|"signature"|"publicKey"|"sequence"|"sigHashType">} TxInputSigned
*/

/**
Expand Down Expand Up @@ -2355,7 +2358,7 @@ if ("object" === typeof module) {
* @param {Uint32} [txInfo.locktime]
* @param {Hex?} [txInfo.extraPayload] - extra payload
* @param {Boolean} [txInfo._debug] - bespoke debug output
* @param {Uint32} [sigHashType]
* @param {Uint32?} [sigHashType]
*/

/**
Expand All @@ -2368,7 +2371,7 @@ if ("object" === typeof module) {
* @param {Array<TxOutput>} txInfo.outputs
* @param {Hex?} [txInfo.extraPayload] - extra payload
* @param {Boolean} [txInfo._debug] - bespoke debug output
* @param {Uint32} sigHashType
* @param {Uint32?} sigHashType
*/

/**
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dashtx",
"version": "0.20.2",
"version": "0.20.3",
"description": "Create DASH Transactions with Vanilla JS (0 deps, cross-platform)",
"main": "dashtx.js",
"module": "dashtx.mjs",
Expand Down