sentence case for "type" diseases (SCA, DM1/DM2)#188
Merged
Conversation
this was bothering me so I fixed it
✅ Deploy Preview for strchive ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lowercase disease
hdashnow
approved these changes
Jun 5, 2025
data/STRchive-loci.json
Outdated
| "unknown_motif_reference_orientation": [], | ||
| "unknown_motif_gene_orientation": [], | ||
| "disease": "Spinocerebellar Ataxia Type 3/Machado-Joseph Disease", | ||
| "disease": "Spinocerebellar ataxia type 3/Machado-Joseph Disease", |
Member
There was a problem hiding this comment.
Should Machado-Joseph Disease be Machado-Joseph disease?
Contributor
Author
|
Yes I think you’re right re: Machado-Joseph disease On Jun 4, 2025, at 6:32 PM, Harriet Dashnow ***@***.***> wrote:
@hdashnow approved this pull request.
In data/STRchive-loci.json:
@@ -657,7 +657,7 @@
"benign_motif_gene_orientation": [],
"unknown_motif_reference_orientation": [],
"unknown_motif_gene_orientation": [],
- "disease": "Spinocerebellar Ataxia Type 3/Machado-Joseph Disease",
+ "disease": "Spinocerebellar ataxia type 3/Machado-Joseph Disease",
Should Machado-Joseph Disease be Machado-Joseph disease?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was bothering me so I fixed it
Description
lowercased some stuff
Minor Changes
Grammatical change
Checklist
CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.