Skip to content

Conversation

@lklimek
Copy link
Contributor

@lklimek lklimek commented Dec 15, 2025

This pull request contains two targeted improvements: one to the logging configuration and another to how wallet seed data is logged. The logging setup is now more flexible and includes more detailed trace information for platform transitions, while the wallet seed is now logged in a more readable format.

Logging improvements:

  • Updated the logger initialization in logging.rs to use environment variables for log filtering if available, falling back to a default filter that now also includes dash_sdk::platform::transition=trace for more granular trace logs. This makes log configuration more flexible and adds deeper visibility into platform transitions.

Wallet seed logging:

  • Changed the logging of wallet_seed in wallet.rs to use hexadecimal encoding, making the output more readable and consistent.

@lklimek lklimek requested a review from Copilot December 15, 2025 13:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/logging-from-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves logging configuration flexibility and readability by enabling environment variable-based log filtering and enhancing wallet seed hash output formatting.

  • Logging now respects the RUST_LOG environment variable, falling back to a comprehensive default filter
  • Added trace-level logging for dash_sdk::platform::transition to provide deeper visibility
  • Wallet seed hash logging changed from debug format to hexadecimal encoding for better readability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/logging.rs Updated logger initialization to use EnvFilter::try_from_default_env() for environment-based configuration with enhanced default filter including platform transition traces
src/database/wallet.rs Changed wallet seed hash logging to use hex::encode() for more readable hexadecimal output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pauldelucia pauldelucia merged commit 466b945 into v1.0-dev Dec 16, 2025
10 checks passed
@pauldelucia pauldelucia deleted the fix/logging-from-env branch December 16, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants