fix: p2sh address send

[pankcuf]

This pull request includes version updates for the DashSharedCore and dash_spv_apple_bindings packages, as well as a code fix in the data_append.rs file to correct the handling of script data. Below is a summary of the most important changes:

Version Updates:

• Updated the version of the DashSharedCore package from 0.5.0 to 0.5.2 in the DashSharedCore.podspec file.
• Updated the version of the dash_spv_apple_bindings package from 0.5.0 to 0.5.2 in the Cargo.toml file.

Code Fixes:

• Fixed the handling of script data in the data_append.rs file by replacing commented-out code with the correct implementation of append_script_push_data for Vec<u8>. This ensures that the script data is properly appended to the writer in two cases involving script_map.pubkey and script_map.script.

Summary by CodeRabbit

• Chores
  • Updated version numbers for DashSharedCore and dash_spv_apple_bindings packages.
• Refactor
  • Improved consistency in data handling within address processing logic.

[coderabbitai]

Walkthrough

This update increases the version numbers for both the DashSharedCore podspec and the dash_spv_apple_bindings Cargo package from 0.5.0 to 0.5.2. Additionally, it refactors method calls in the Rust file data_append.rs to standardize the invocation of append_script_push_data, with no changes to logic or public interfaces.

Changes

File(s)	Change Summary
DashSharedCore.podspec, dash-spv-apple-bindings/Cargo.toml	Bumped version numbers from 0.5.0 to 0.5.2
dash-spv-masternode-processor/src/util/data_append.rs	Refactored append_script_push_data calls for consistency; removed commented-out alternative

Possibly related PRs

• chore: bump podspec and crate version #106: Updated version numbers from earlier versions to 0.5.0 in the same files, similar to this PR's version bump from 0.5.0 to 0.5.2.

Poem

A hop and a skip, the numbers ascend,
From zero point five, to two at the end!
Refactored the code, so tidy and neat,
Versioning bunnies just can’t be beat.
With scripts now consistent, and numbers anew,
This rabbit says, “Ship it!”—the work here is through!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

dash-spv-masternode-processor/src/util/data_append.rs (1)

196-197: Consider improving error handling consistency.

The implementation uses writer.write(self).expect(...) which panics on write errors, while most other methods in this file use .enc(&mut writer). Consider whether consistent error handling patterns should be applied across the codebase.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 014882a and 5f7f00b.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• DashSharedCore.podspec (1 hunks)
• dash-spv-apple-bindings/Cargo.toml (1 hunks)
• dash-spv-masternode-processor/src/util/data_append.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Cargo test

🔇 Additional comments (3)

dash-spv-apple-bindings/Cargo.toml (1)

3-3: Version bump looks good.

The version update from 0.5.0 to 0.5.2 aligns with the coordinated release across the project components.

DashSharedCore.podspec (1)

3-3: Version synchronization maintained.

The version update to '0.5.2' correctly maintains consistency with the corresponding Cargo.toml version bump.

dash-spv-masternode-processor/src/util/data_append.rs (1)

143-143: Method call now aligns with trait definition.

The fix correctly changes the method invocation to call append_script_push_data on the data vector rather than the writer, which aligns with the trait definition at line 22 and maintains consistency with other calls in the codebase.

[Syn-McJ]

Looks good