backport: bitcoin-core#gui18, #121, #257, #263, #281, #335, #362, #828, bitcoin#21912, #21942, #21988

src/qt/bitcoingui.cpp

@@ -520,10 +520,9 @@ void BitcoinGUI::createActions()
             for (const std::pair<const std::string, bool>& i : m_wallet_controller->listWalletDir()) {
                 const std::string& path = i.first;
                 QString name = path.empty() ? QString("["+tr("default wallet")+"]") : QString::fromStdString(path);
-                // Menu items remove single &. Single & are shown when && is in
-                // the string, but only the first occurrence. So replace only
-                // the first & with &&.
-                name.replace(name.indexOf(QChar('&')), 1, QString("&&"));
+                // An single ampersand in the menu item's text sets a shortcut for this item.
+                // Single & are shown when && is in the string. So replace & with &&.
+                name.replace(QChar('&'), QString("&&"));
                 QAction* action = m_open_wallet_menu->addAction(name);
 
                 if (i.second) {

src/qt/governancelist.cpp

@@ -387,8 +387,11 @@ void GovernanceList::showProposalContextMenu(const QPoint& pos)
         return;
     }
 
+    QString proposal_url = proposal->url();
+    proposal_url.replace(QChar('&'), QString("&&"));
+
     // right click menu with option to open proposal url
-    QAction* openProposalUrl = new QAction(proposal->url(), this);
+    QAction* openProposalUrl = new QAction(proposal_url, this);
     proposalContextMenu->clear();
     proposalContextMenu->addAction(openProposalUrl);
     connect(openProposalUrl, &QAction::triggered, proposal, &Proposal::openUrl);