Skip to content

backport: Merge bitcoin#24067#6307

Closed
vijaydasmp wants to merge 1 commit intodashpay:developfrom
vijaydasmp:bp23_2024_10_04
Closed

backport: Merge bitcoin#24067#6307
vijaydasmp wants to merge 1 commit intodashpay:developfrom
vijaydasmp:bp23_2024_10_04

Conversation

@vijaydasmp
Copy link

@vijaydasmp vijaydasmp commented Oct 4, 2024

No description provided.

@vijaydasmp vijaydasmp changed the title backport : Merge bitcoin/bitcoin#24067: backport : Merge bitcoin#24067 Oct 4, 2024
@github-actions
Copy link

github-actions bot commented Oct 26, 2024

This pull request has conflicts, please rebase.

@github-actions
Copy link

github-actions bot commented Dec 15, 2024

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the bp23_2024_10_04 branch 2 times, most recently from 9ab4917 to 0f2ee08 Compare December 30, 2024 12:22
@vijaydasmp vijaydasmp changed the title backport : Merge bitcoin#24067 backport: Merge bitcoin#24067 Dec 30, 2024
@vijaydasmp vijaydasmp force-pushed the bp23_2024_10_04 branch 2 times, most recently from 095a0d2 to 90a1c44 Compare January 2, 2025 03:27
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the bp23_2024_10_04 branch 2 times, most recently from 6e5dcdd to 6a63e73 Compare February 8, 2025 14:51
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

This pull request has conflicts, please rebase.

@achow101 @vijaydasmp
Merge bitcoin#24067: wallet: Actually treat (un)confirmed txs as (un)…
918cc22 
…confirmed

fac8165 Remove unused checkFinalTx (MarcoFalke)
fa272ea wallet: Avoid dropping confirmed coins (MarcoFalke)
888841e interfaces: Remove unused is_final (MarcoFalke)
dddd05e qt: Treat unconfirmed txs as unconfirmed (MarcoFalke)

Pull request description:

  The wallet has several issues:

  ## Unconfirmed txs in the GUI

  The GUI clumsily attempts to guess if unconfirmed txs are locked until a future time. This is currently based on the locktime only, not nSequence, thus wrong. Fix this by removing the clumsy code and treat all unconfirmed txs as unconfirmed. The GUI already prints whether a tx is in the mempool, in which case the user knows that the tx wasn't locked until a future time. If the tx is not in the mempool, it might be better to report the exact reject reason from the mempool instead of using incorrect heuristics.

  ## Confirmed txs in the wallet

  The wallet drops coins that it incorrectly assumes to be locked until a future time, even if they are already confirmed in the chain. This is because the wallet is using the wrong time (adjusted network time) instead of MTP, due to the `-1` default argument of `CheckFinalTx`.

  The issues are fixed in separate commits and there is even a test.

ACKs for top commit:
  achow101:
    ACK fac8165
  prayank23:
    reACK bitcoin@fac8165
  glozow:
    code review ACK fac8165, I understand now how this fixes both issues.

Tree-SHA512: 210afb855f4c6d903fee49eba6b1a9735d699cf0168b669eabb38178e53b3a522258b7cc669f52489c6cd3e38bf358afde12eef3ba2e2f2ffaeb06b8f652ccd0
@github-actions
Copy link

github-actions bot commented May 1, 2025

This pull request has conflicts, please rebase.

@DashCoreAutoGuix
Copy link

DashCoreAutoGuix commented Jul 28, 2025

❌ Backport Verification - CATASTROPHIC FAILURE

Original Bitcoin commit: e30b6ea194
Reviewed commit hash: 918cc22d06-verify-1753726707

Critical violations:

  • Extreme Staleness: PR is 929 commits behind develop (unmaintainable)
  • Catastrophic CI Failures: 10 out of 30 CI jobs failing across all build platforms
  • Multiple Merge Conflicts: Bot has repeatedly requested rebases since October 2024
  • Build System Incompatibility: Core build infrastructure has diverged significantly

Analysis:
This PR represents Bitcoin Core PR bitcoin#24067 ("wallet: Actually treat (un)confirmed txs as (un)confirmed") but has become unmaintainable due to being severely outdated. The extensive CI failures indicate fundamental compatibility issues with the current Dash codebase that would require essentially recreating the entire backport.

CI Status: 10/30 failures including:

  • linux64_tsan-build, linux64_multiprocess-build, win64-build
  • arm-linux-build, linux64_sqlite-build, linux64_ubsan-build
  • linux64-build, mac-build, x86_64-pc-linux-gnu_nowallet
  • GitLab pipeline failures

Recommendation:
This PR should be auto-closed and recreated with a fresh backport based on current develop branch. The changes from Bitcoin bitcoin#24067 remain valid but need to be applied to the current codebase.

This PR has been automatically closed. Please create a new PR with a proper backport based on current develop branch.

@DashCoreAutoGuix
Copy link

DashCoreAutoGuix commented Jul 28, 2025

Automatically closed due to catastrophic validation failures. Please see the detailed analysis above and create a new PR with a proper backport implementation.

@vijaydasmp vijaydasmp closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vijaydasmp @DashCoreAutoGuix @achow101