refactor: drop static IsMNPoSeBanned and IsMNValid which are confusing

[knst]

Issue being fixed or feature implemented

This methods are static, but they are confusing, because their usage such as IsMNValid(*p.second); or mnList.IsMNValid(dmn) looks like it does something with CDeterministicMNList; but all data contained inside CDeterministicMNState (dmn) object.

What was done?

Dropped static methods IsMNValid and IsMNPoSeBanned from CDeterministicMNList. Non-static methods with same name that uses proTx still exist and are not changed.

How Has This Been Tested?

Run unit / functional tests

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[coderabbitai]

Walkthrough

The changes remove redundant wrapper functions for determining masternode validity and PoSe ban status, replacing them with direct checks on the masternode's internal banned state (pdmnState->IsBanned()). All logic for validating, filtering, and counting masternodes is updated to use this direct check instead of intermediary methods. The static methods IsMNValid(const CDeterministicMN&) and IsMNPoSeBanned(const CDeterministicMN&) are deleted from both the implementation and the class interface. RPC handling code is also updated to use the new direct approach for ban status evaluation, simplifying status mapping and filtering logic. No changes are made to public API signatures.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da8a475 and 9e636d0.

📒 Files selected for processing (3)

• src/evo/deterministicmns.cpp (4 hunks)
• src/evo/deterministicmns.h (4 hunks)
• src/rpc/masternode.cpp (2 hunks)

🧰 Additional context used

🪛 GitHub Actions: Clang Diff Format Check

src/rpc/masternode.cpp

[error] 573-660: Clang format differences found. The file does not conform to the required code style. Please run clang-format to fix formatting issues.

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: build (arm64-apple-darwin)
• GitHub Check: build (x86_64-apple-darwin)
• GitHub Check: build (aarch64-linux-gnu)
• GitHub Check: build (powerpc64-linux-gnu)
• GitHub Check: build (riscv64-linux-gnu)
• GitHub Check: build (x86_64-w64-mingw32)
• GitHub Check: build (arm-linux-gnueabihf)
• GitHub Check: build (x86_64-linux-gnu)
• GitHub Check: Build container / Build container
• GitHub Check: Build slim container / Build container

🔇 Additional comments (12)

src/rpc/masternode.cpp (3)

520-523: Code simplification improves clarity

The direct check of dmn.pdmnState->IsBanned() is cleaner than using the previously available wrapper function. This removes an unnecessary indirection and makes the intent clearer.

---

539-540: Consistent use of direct state access

This change aligns with the overall refactoring by directly checking the ban state on the masternode state object rather than using the wrapper method.

---

573-660:

Details

❓ Verification inconclusive

Fix code formatting issue

The pipeline has detected a formatting issue in this section of the file.

---

🏁 Script executed:

#!/bin/bash
# Check which lines have formatting issues
clang-format -style=file --dry-run --Werror src/rpc/masternode.cpp | grep -A 3 "error"

Length of output: 189

---

Manual formatting check required

The sandbox environment doesn’t have clang-format installed, so automated checks couldn’t run. Please verify and fix any formatting issues in src/rpc/masternode.cpp (lines 573–660) by running locally:

clang-format -style=file --dry-run --Werror src/rpc/masternode.cpp

🧰 Tools

🪛 GitHub Actions: Clang Diff Format Check

[error] 573-660: Clang format differences found. The file does not conform to the required code style. Please run clang-format to fix formatting issues.

src/evo/deterministicmns.h (5)

224-224: Code simplification improves clarity and consistency

The direct check of banned state is more straightforward and makes it clearer that masternode validity is determined by the ban status.

---

234-236: Consistent validation approach for Evo nodes

The direct check on pdmnState->IsBanned() maintains consistency with the other methods in this class that now use the same pattern.

---

242-242: Direct ban state check for weighted count

This change maintains the consistent approach of directly checking the ban state rather than using the removed static method.

---

257-257: Simplified filtering logic in ForEachMN

The ban state is now checked directly, making the code more readable and removing an unnecessary layer of indirection.

---

274-274: Consistent approach in ForEachMNShared

This change follows the same pattern as in ForEachMN, ensuring consistency across similar methods.

src/evo/deterministicmns.cpp (4)

72-72: Simplified implementation of IsMNValid

The function now directly returns the negation of the banned state, which is clearer and avoids an unnecessary call to the removed static method.

---

81-81: Simplified implementation of IsMNPoSeBanned

The function now directly returns the banned state, which is clearer and avoids an unnecessary call to the removed static method.

---

96-97: Consistent validation check in GetValidMN

This change maintains consistency with the other methods that now directly check the ban state.

---

120-121: Consistent validation check in GetValidMNByCollateral

Similar to GetValidMN, this method now directly checks the ban state, maintaining consistency across the codebase.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kwvg]

utACK 9e636d0

[UdjinM6]

utACK 9e636d0