Skip to content

refactor: remove unused spork.h usages all over codebase#7179

Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom
knst:refactor-includes-spork
Feb 27, 2026
Merged

refactor: remove unused spork.h usages all over codebase#7179
PastaPastaPasta merged 2 commits intodashpay:developfrom
knst:refactor-includes-spork

Conversation

@knst
Copy link
Collaborator

@knst knst commented Feb 26, 2026

What was done?

See commits. Removed stub or useless spork includes and initialization.

How Has This Been Tested?

Run unit & functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@knst knst added this to the 24 milestone Feb 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c0f42a and 0a2a27d.

📒 Files selected for processing (8)
  • src/node/miner.cpp
  • src/qt/walletmodel.cpp
  • src/rpc/mining.cpp
  • src/test/blockfilter_index_tests.cpp
  • src/test/evo_deterministicmns_tests.cpp
  • src/test/miner_tests.cpp
  • src/test/util/mining.cpp
  • src/test/validation_chainstatemanager_tests.cpp
💤 Files with no reviewable changes (8)
  • src/test/evo_deterministicmns_tests.cpp
  • src/rpc/mining.cpp
  • src/test/blockfilter_index_tests.cpp
  • src/test/validation_chainstatemanager_tests.cpp
  • src/node/miner.cpp
  • src/test/util/mining.cpp
  • src/test/miner_tests.cpp
  • src/qt/walletmodel.cpp

Walkthrough

This pull request removes the spork.h header include from eight source files across production code, RPC, Qt, and test modules. In one test file (evo_deterministicmns_tests.cpp), related spork key initialization code is also removed. The changes eliminate unused dependencies without modifying control flow or functionality in the remaining code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing unused spork.h includes across the codebase.
Description check ✅ Passed The description is related to the changeset, explaining what was done (removed stub/useless spork includes) and how it was tested.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0a2a27d

@PastaPastaPasta PastaPastaPasta merged commit f63e423 into dashpay:develop Feb 27, 2026
42 of 43 checks passed
@knst knst deleted the refactor-includes-spork branch March 6, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants