ci: restrict guix build to tagged pushes and labeled PRs only#7194
Closed
thepastaclaw wants to merge 1 commit intodashpay:developfrom
Closed
ci: restrict guix build to tagged pushes and labeled PRs only#7194thepastaclaw wants to merge 1 commit intodashpay:developfrom
thepastaclaw wants to merge 1 commit intodashpay:developfrom
Conversation
Previously, the Guix Build workflow triggered on all push events (branches and tags), relying solely on the job-level `if` condition to skip non-tag branch pushes. This caused unnecessary workflow runs to appear (as skipped) on every PR push. Restrict the push trigger to tags only, so the workflow is never triggered by regular branch pushes. The existing job-level condition is kept as defense-in-depth. For PRs, the workflow continues to require the `guix-build` label.
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restrict the Guix Build CI workflow to only trigger on:
guix-buildlabelPreviously, the workflow triggered on all push events (every branch push), relying on the job-level
ifcondition to skip non-tag pushes. While functionally correct, this created unnecessary skipped workflow runs on every PR update.Changes
tags: ['*']filter to thepushtrigger, so only tag pushes fire the workflowifcondition is kept as defense-in-depthTesting
No functional change — the workflow already skipped non-tag branch pushes via the
ifcondition. This change prevents the workflow from being triggered at all on branch pushes.