Skip to content

Conversation

@bfoss765
Copy link
Contributor

@bfoss765 bfoss765 commented Jan 7, 2026

Summary

  • Bump version to 8.5.3 across all targets
  • Update DashSync to commit be4f7c1

Test plan

  • Verify app builds successfully
  • Confirm version displays as 8.5.3 in app settings
  • Test that DashSync integration works correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Bumped application version from 8.5.2 to 8.5.3 across build configurations.
    • Switched test and archive schemes to use release-oriented build settings.
    • Applied a minor metadata value update (non-functional) with no user-facing impact.

✏️ Tip: You can customize this high-level summary in your review settings.

- Update MARKETING_VERSION to 8.5.3 across all targets
- Update DashSyncCurrentCommit to be4f7c1

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

Updated Xcode project marketing version from 8.5.2 to 8.5.3 across build configurations, adjusted scheme build/archive configurations, and updated the DashSync current commit hash value.

Changes

Cohort / File(s) Summary
Build Configuration
DashWallet.xcodeproj/project.pbxproj
Updated MARKETING_VERSION from 8.5.28.5.3 across multiple XCBuildConfiguration blocks (Debug, Release, Testnet, Testflight) for app, extensions, and test targets
Build Scheme
DashWallet.xcodeproj/xcshareddata/xcschemes/dashwallet.xcscheme
Changed TestAction buildConfiguration DebugRelease; changed ArchiveAction buildConfiguration TestflightRelease
Build Metadata
DashSyncCurrentCommit
Replaced commit reference 753f9446cfd20ae5da996104a5870df839005d4cc97bdeaadada89fbe7f1a59ceea89ae531a1bcb9

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged a tag, I hopped a bit,
Numbers rose and hashes fit,
Schemes aligned, the builds now sing,
Tiny change — a springtime spring. 🌸

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions improving logging and bumping version to 8.5.3, which matches the file changes showing version updates across build configurations and DashSync commit updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems in this PR.

bfoss765 and others added 3 commits January 9, 2026 15:30
- Update DashSyncCurrentCommit to f5c4a3e1
- Update dashwallet.xcscheme build configurations

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates DashSync with code review feedback:
- Remove unreachable else branch in DSFundsDerivationPath
- Fix dispatch_async to dispatch_sync in DSChainSyncSpeedCalculator reset
- Restore logging in DSAccount, DSCoinJoinManager, DSPeerManager, DSMasternodeGroup, DSCoinJoinWrapper

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates DashSync with:
- Restore missing CoinJoin event logging (printUsedKeys, onSessionStarted,
  onSessionComplete, onMixingStarted, onTransactionProcessed)
- Add explicit git workflow policy to CLAUDE.md

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bfoss765 bfoss765 merged commit 4b1cf20 into master Jan 22, 2026
3 checks passed
@bfoss765 bfoss765 deleted the feat/improve-logging branch January 22, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants