-
Notifications
You must be signed in to change notification settings - Fork 22
feat: improve logging and bump version to 8.5.3 #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update MARKETING_VERSION to 8.5.3 across all targets - Update DashSyncCurrentCommit to be4f7c1 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughUpdated Xcode project marketing version from 8.5.2 to 8.5.3 across build configurations, adjusted scheme build/archive configurations, and updated the DashSync current commit hash value. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
HashEngineering
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems in this PR.
- Update DashSyncCurrentCommit to f5c4a3e1 - Update dashwallet.xcscheme build configurations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates DashSync with code review feedback: - Remove unreachable else branch in DSFundsDerivationPath - Fix dispatch_async to dispatch_sync in DSChainSyncSpeedCalculator reset - Restore logging in DSAccount, DSCoinJoinManager, DSPeerManager, DSMasternodeGroup, DSCoinJoinWrapper Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Updates DashSync with: - Restore missing CoinJoin event logging (printUsedKeys, onSessionStarted, onSessionComplete, onMixingStarted, onTransactionProcessed) - Add explicit git workflow policy to CLAUDE.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
HashEngineering
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.