docs: update special txs with extended address info #536
Conversation
WalkthroughProvider transaction docs updated to document Versions 1–3, introduce a Version 3+ Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🧰 Additional context used🧠 Learnings (5)📓 Common learnings📚 Learning: 2025-11-10T18:51:37.016ZApplied to files:
📚 Learning: 2025-11-10T17:22:58.160ZApplied to files:
📚 Learning: 2025-11-10T19:11:33.355ZApplied to files:
📚 Learning: 2025-11-12T18:09:41.377ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
docs/core/reference/transactions-special-transactions.md (3)
56-57: Apply hyphenation to compound adjectives.Lines 56 and 57 use "owner related" and "operational related" as compound adjectives modifying "signing". These should be hyphenated per standard English grammar.
-| 20 | KeyIdOwner | CKeyID | The public key hash used for owner related signing (ProTx updates, governance voting) +| 20 | KeyIdOwner | CKeyID | The public key hash used for owner-related signing (ProTx updates, governance voting)-| 48 | PubKeyOperator | CBLSPublicKey | The BLS public key used for operational related signing (network messages, ProTx updates).<br>**Note**: serialization varies based on `version`:<br> - Version 1 - legacy BLS scheme<br> - Version 2+ - basic BLS scheme +| 48 | PubKeyOperator | CBLSPublicKey | The BLS public key used for operational-related signing (network messages, ProTx updates).<br>**Note**: serialization varies based on `version`:<br> - Version 1 - legacy BLS scheme<br> - Version 2+ - basic BLS scheme
65-65: Remove redundant phrasing in "HTTP/API interface" descriptions.Both lines 65 and 305 say "TCP port of Platform HTTP/API interface". Since "I" in "interface" creates redundancy, simplify to "TCP port of Platform HTTP/API" or similar.
-| 0 or 2 | platformHTTPPort | uint_16 | ***Version 2 only***<br>TCP port of Platform HTTP/API interface (network byte order). Only present for masternode type 1.<br>**Replaced by netInfo in version 3** +| 0 or 2 | platformHTTPPort | uint_16 | ***Version 2 only***<br>TCP port of Platform HTTP/API (network byte order). Only present for masternode type 1.<br>**Replaced by netInfo in version 3**Also applies to: 305-305
440-440: Apply hyphenation to compound adjective in ProUpRegTx section.Line 440 uses "operational related" as a compound adjective. Hyphenate for consistency and correct grammar.
-| 48 | PubKeyOperator | CBLSPublicKey | The BLS public key used for operational related signing (network messages, ProTx updates).<br>**Note**: serialization varies based on `version`:<br> - Version 1 - legacy BLS scheme<br> - Version 2+ - basic BLS scheme +| 48 | PubKeyOperator | CBLSPublicKey | The BLS public key used for operational-related signing (network messages, ProTx updates).<br>**Note**: serialization varies based on `version`:<br> - Version 1 - legacy BLS scheme<br> - Version 2+ - basic BLS scheme
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/core/reference/transactions-special-transactions.md(4 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-call-quick-reference.md:34-34
Timestamp: 2025-11-10T17:22:58.160Z
Learning: In the dashpay/docs repository, RPC documentation descriptions in files like `docs/core/api/remote-procedure-call-quick-reference.md` are derived from the Dash Core application help output. These descriptions should not be modified for grammar or style, as they need to remain consistent with the source application output.
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-evo.md:1493-1494
Timestamp: 2025-11-10T17:45:04.767Z
Learning: In docs/core/api/remote-procedure-calls-evo.md, the platformHTTPSAddrs parameter in ProTx commands (like protx register_fund_evo) has type `number/string/array` because Dash Core v23.0.0 maintains backwards compatibility by still accepting just a port number (the old platformHTTPPort format), in addition to accepting the new string or array of strings in `ADDR:PORT` format.
📚 Learning: 2025-11-10T18:51:37.016Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
Applied to files:
docs/core/reference/transactions-special-transactions.md
📚 Learning: 2025-11-10T17:45:04.767Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-evo.md:1493-1494
Timestamp: 2025-11-10T17:45:04.767Z
Learning: In docs/core/api/remote-procedure-calls-evo.md, the platformHTTPSAddrs parameter in ProTx commands (like protx register_fund_evo) has type `number/string/array` because Dash Core v23.0.0 maintains backwards compatibility by still accepting just a port number (the old platformHTTPPort format), in addition to accepting the new string or array of strings in `ADDR:PORT` format.
Applied to files:
docs/core/reference/transactions-special-transactions.md
🪛 LanguageTool
docs/core/reference/transactions-special-transactions.md
[grammar] ~56-~56: Use a hyphen to join words.
Context: ...yID | The public key hash used for owner related signing (ProTx updates, governan...
(QB_NEW_EN_HYPHEN)
[grammar] ~57-~57: Use a hyphen to join words.
Context: ... The BLS public key used for operational related signing (network messages, ProTx...
(QB_NEW_EN_HYPHEN)
[style] ~65-~65: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ... 2 only***
TCP port of Platform HTTP/API interface (network byte order). Only present for ...
(ACRONYM_TAUTOLOGY)
[style] ~305-~305: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ... 2 only***
TCP port of Platform HTTP/API interface (network byte order). Only present for ...
(ACRONYM_TAUTOLOGY)
[grammar] ~440-~440: Use a hyphen to join words.
Context: ... The BLS public key used for operational related signing (network messages, ProTx...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/core/reference/transactions-special-transactions.md
49-49: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
50-50: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
51-51: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
52-52: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
53-53: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
54-54: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
55-55: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
56-56: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
57-57: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
58-58: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
59-59: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
60-60: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
61-61: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
62-62: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
63-63: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
64-64: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
65-65: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
66-66: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
67-67: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
75-75: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
76-76: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
294-294: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
295-295: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
296-296: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
297-297: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
298-298: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
299-299: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
300-300: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
301-301: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
302-302: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
303-303: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
304-304: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
305-305: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
306-306: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
307-307: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
437-437: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
438-438: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
439-439: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
440-440: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
582-582: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
583-583: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
584-584: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
585-585: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
586-586: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
587-587: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
🔇 Additional comments (5)
docs/core/reference/transactions-special-transactions.md (5)
69-78: NetInfo Structure section is well-documented with clear versioning.The new NetInfo Structure section provides comprehensive documentation of the extensible address format, clearly explaining purpose IDs (0-2) and address types. The note at line 78 appropriately clarifies the relationship between version 3 transactions and the new structure.
49-67: ProRegTx versioning documentation is clear and comprehensive.The version field updates (line 49) and version-specific field documentation for ipAddress/port (lines 53–54) and the new netInfo field (line 55) are well-structured. Platform-specific fields (lines 63–65) are correctly marked as version 2 only with netInfo replacement in version 3. The payload signature note (line 67) appropriately distinguishes BLS scheme variants by version.
294-309: ProUpServTx versioning mirrors ProRegTx updates appropriately.Version descriptions (line 294), version-conditional field annotations (lines 297–305), and the note differentiating version 1 from version 3 transactions (line 309) follow the same clear pattern as ProRegTx documentation. The type field annotation (line 295) correctly specifies "Version 2 and later".
437-446: ProUpRegTx versioning documentation is consistent with overall versioning scheme.Version descriptions (line 437) and signature serialization notes (line 440 — pending hyphenation fix noted above) appropriately document version-specific behavior. The ProUpRegTx structure correctly reflects version variants without the network address fields present in ProRegTx/ProUpServTx.
582-587: ProUpRevTx versioning and signature documentation is accurate.Version descriptions (line 582) and the note about automatic version selection by the
protx revokeRPC add helpful context. Signature serialization variants (line 587) clearly distinguish legacy vs. basic BLS schemes. Documentation correctly omits network address fields.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/core/reference/transactions-special-transactions.md (2)
49-67: Optional: Consider adding trailing pipes to markdown tables for strict compliance.Markdown linter flags missing trailing pipes in table rows throughout the file (MD055). While most renderers handle this gracefully, adding trailing pipes would improve consistency:
-| 2 | version | uint_16 | Provider transaction version number.<br>... +| 2 | version | uint_16 | Provider transaction version number.<br>... |This applies to all table rows in the ProRegTx, NetInfo, ProUpServTx, ProUpRegTx, and ProUpRevTx tables.
Also applies to: 73-76, 294-307, 437-446, 580-587
56-57: Optional: Apply minor grammar/style improvements for formality.Consider these stylistic refinements:
- Lines 56–57, 440: Use hyphens for compound modifiers: "owner-related" and "operational-related" (not "owner related")
- Lines 65, 305: Remove redundant "interface" in "HTTP/API interface" → "HTTP/API" (since API already implies interface)
These changes would improve documentation consistency and formality, but are not critical.
Also applies to: 65-65, 305-305, 440-440
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/core/reference/transactions-special-transactions.md(4 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-evo.md:1493-1494
Timestamp: 2025-11-10T17:45:04.767Z
Learning: In docs/core/api/remote-procedure-calls-evo.md, the platformHTTPSAddrs parameter in ProTx commands (like protx register_fund_evo) has type `number/string/array` because Dash Core v23.0.0 maintains backwards compatibility by still accepting just a port number (the old platformHTTPPort format), in addition to accepting the new string or array of strings in `ADDR:PORT` format.
📚 Learning: 2025-11-10T18:51:37.016Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
Applied to files:
docs/core/reference/transactions-special-transactions.md
📚 Learning: 2025-11-10T17:45:04.767Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-evo.md:1493-1494
Timestamp: 2025-11-10T17:45:04.767Z
Learning: In docs/core/api/remote-procedure-calls-evo.md, the platformHTTPSAddrs parameter in ProTx commands (like protx register_fund_evo) has type `number/string/array` because Dash Core v23.0.0 maintains backwards compatibility by still accepting just a port number (the old platformHTTPPort format), in addition to accepting the new string or array of strings in `ADDR:PORT` format.
Applied to files:
docs/core/reference/transactions-special-transactions.md
🪛 LanguageTool
docs/core/reference/transactions-special-transactions.md
[grammar] ~56-~56: Use a hyphen to join words.
Context: ...yID | The public key hash used for owner related signing (ProTx updates, governan...
(QB_NEW_EN_HYPHEN)
[grammar] ~57-~57: Use a hyphen to join words.
Context: ... The BLS public key used for operational related signing (network messages, ProTx...
(QB_NEW_EN_HYPHEN)
[style] ~65-~65: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ... 2 only***
TCP port of Platform HTTP/API interface (network byte order). Only present for ...
(ACRONYM_TAUTOLOGY)
[style] ~305-~305: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ... 2 only***
TCP port of Platform HTTP/API interface (network byte order). Only present for ...
(ACRONYM_TAUTOLOGY)
[grammar] ~440-~440: Use a hyphen to join words.
Context: ... The BLS public key used for operational related signing (network messages, ProTx...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
docs/core/reference/transactions-special-transactions.md
49-49: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
50-50: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
51-51: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
52-52: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
53-53: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
54-54: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
55-55: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
56-56: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
57-57: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
58-58: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
59-59: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
60-60: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
61-61: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
62-62: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
63-63: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
64-64: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
65-65: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
66-66: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
67-67: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
75-75: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
76-76: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
294-294: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
295-295: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
296-296: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
297-297: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
298-298: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
299-299: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
300-300: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
301-301: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
302-302: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
303-303: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
304-304: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
305-305: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
306-306: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
307-307: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
437-437: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
438-438: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
439-439: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
440-440: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
582-582: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
583-583: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
584-584: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
585-585: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
586-586: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
587-587: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
(MD055, table-pipe-style)
🔇 Additional comments (3)
docs/core/reference/transactions-special-transactions.md (3)
49-49: NetInfo Structure documentation and version descriptions are well-structured.The addition of Version 3 support with the NetInfo Structure is clearly documented. Version constraints (< 3 for ipAddress/port, 3+ for netInfo) are properly marked, and the cross-reference from line 55 correctly anchors to
#netinfo-structure. The subsection explanation at lines 69–78 provides necessary context about the purpose map and how v3 differs from earlier versions.Also applies to: 53-78
290-309: ProUpServTx documentation is consistent with ProRegTx versioning.Version constraints, netInfo replacement notes, and BLS serialization updates are aligned across both transaction types. The corrected anchor reference at line 299 now properly links to
#netinfo-structure. The explanatory note at line 309 parallels the ProRegTx structure, maintaining consistency.
437-587: ProUpRegTx and ProUpRevTx sections maintain consistent versioning patterns.Both sections properly document Versions 1–3 with appropriate serialization notes. ProUpRevTx notably adds helpful context about automatic version selection by the
protx revokeRPC (line 582), and the BLS serialization notes are correctly updated across both transaction types. The documentation maintains consistency with earlier sections.
1 participant
Summary by CodeRabbit
Preview build: https://dash-docs--536.org.readthedocs.build/en/536/