Skip to content

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented Dec 4, 2025

Fixes dead links reported by @Fible1

Preview build: https://dash-docs--545.org.readthedocs.build/en/545/

Summary by CodeRabbit

  • Documentation
    • Reorganized mining pools listing with updated table format and pool entries
    • Redesigned ASIC miners table with simplified layout and adjusted headers
    • Removed pricing information from miners table
    • Reordered and reformatted miner entries for improved clarity
    • Updated reseller information with new options

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Walkthrough

Documentation updates to the mining index page, including reordering pool entries, restructuring the ASIC miners table to remove the Price column and adjust column headers, reformatting pool listings from plain text to table format, and updating the reseller section with new entries.

Changes

Cohort / File(s) Summary
Mining Documentation Restructuring
docs/user/mining/index.rst
Reordered pool entries and reformatted pool listings; restructured ASIC miners table (removed Price column, adjusted headers to Name, Hash rate, Power, Weight, Dimensions); updated reseller listings with new entries

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Multiple distinct formatting and content changes across the same documentation file
  • Verify pool entry accuracy and reseller links
  • Confirm table column removals and reordering do not omit important information

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove dead links from mining page' accurately summarizes the main change of updating mining page links and removing invalid URLs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a669c9a and d6ec223.

📒 Files selected for processing (1)
  • docs/user/mining/index.rst (2 hunks)
🔇 Additional comments (1)
docs/user/mining/index.rst (1)

86-91: Verify mining pool URLs are reachable.

The PR title indicates dead links were removed, but URL accessibility cannot be verified in this review environment. Before merging, manually test the mining pool links (antpool.com, f2pool.com, miningpoolhub.com, nicehash.com, viabtc.com, zpool.ca) to confirm they are active and not dead links.

@thephez thephez merged commit 6482083 into dashpay:23.0.0 Dec 4, 2025
2 checks passed
@thephez thephez deleted the chore/mining-link-update branch December 4, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant