chore: Remove StorageStats (#283)

Author: ZocoLini

dash-spv/src/storage/mod.rs

@@ -157,9 +157,6 @@ pub trait StorageManager: Send + Sync {
     /// Clear all filter headers and compact filters.
     async fn clear_filters(&mut self) -> StorageResult<()>;
 
-    /// Get storage statistics.
-    async fn stats(&self) -> StorageResult<StorageStats>;
-
     /// Get header height by block hash (reverse lookup).
     async fn get_header_height_by_hash(
         &self,

dash-spv/src/storage/state.rs

@@ -9,7 +9,7 @@ use dashcore_hashes::Hash;
 
 use crate::error::StorageResult;
 use crate::storage::manager::WorkerCommand;
-use crate::storage::{MasternodeState, StorageManager, StorageStats};
+use crate::storage::{MasternodeState, StorageManager};
 use crate::types::{ChainState, MempoolState, UnconfirmedTransaction};
 
 use super::io::atomic_write;
@@ -268,40 +268,6 @@ impl DiskStorageManager {
         Ok(())
     }
 
-    /// Get storage statistics.
-    pub async fn stats(&self) -> StorageResult<StorageStats> {
-        let mut component_sizes = HashMap::new();
-        let mut total_size = 0u64;
-
-        // Calculate directory sizes
-        if let Ok(mut entries) = tokio::fs::read_dir(&self.base_path).await {
-            while let Ok(Some(entry)) = entries.next_entry().await {
-                if let Ok(metadata) = entry.metadata().await {
-                    if metadata.is_file() {
-                        total_size += metadata.len();
-                    }
-                }
-            }
-        }
-
-        let header_count = self.block_headers.read().await.tip_height().map_or(0, |h| h as u64 + 1);
-        let filter_header_count =
-            self.filter_headers.read().await.tip_height().map_or(0, |h| h as u64 + 1);
-
-        component_sizes.insert("headers".to_string(), header_count * 80);
-        component_sizes.insert("filter_headers".to_string(), filter_header_count * 32);
-        component_sizes
-            .insert("index".to_string(), self.header_hash_index.read().await.len() as u64 * 40);
-
-        Ok(StorageStats {
-            header_count,
-            filter_header_count,
-            filter_count: 0, // TODO: Count filter files
-            total_size,
-            component_sizes,
-        })
-    }
-
     /// Shutdown the storage manager.
     pub async fn shutdown(&mut self) {
         // Persist all dirty data
@@ -503,10 +469,6 @@ impl StorageManager for DiskStorageManager {
         Ok(())
     }
 
-    async fn stats(&self) -> StorageResult<StorageStats> {
-        Self::stats(self).await
-    }
-
     async fn get_header_height_by_hash(&self, hash: &BlockHash) -> StorageResult<Option<u32>> {
         Self::get_header_height_by_hash(self, hash).await
     }

dash-spv/src/storage/types.rs

@@ -1,7 +1,6 @@
 //! Storage-related types and structures.
 
 use serde::{Deserialize, Serialize};
-use std::collections::HashMap;
 
 /// Masternode state for storage.
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -15,22 +14,3 @@ pub struct MasternodeState {
     /// Last update timestamp.
     pub last_update: u64,
 }
-
-/// Storage statistics.
-#[derive(Debug, Clone, Default)]
-pub struct StorageStats {
-    /// Number of headers stored.
-    pub header_count: u64,
-
-    /// Number of filter headers stored.
-    pub filter_header_count: u64,
-
-    /// Number of filters stored.
-    pub filter_count: u64,
-
-    /// Total storage size in bytes.
-    pub total_size: u64,
-
-    /// Individual component sizes.
-    pub component_sizes: HashMap<String, u64>,
-}

dash-spv/tests/segmented_storage_test.rs

@@ -324,11 +324,6 @@ async fn test_mixed_operations() {
 
     assert_eq!(storage.load_metadata("test_key").await.unwrap().unwrap(), b"test_value");
 
-    // Get stats
-    let stats = storage.stats().await.unwrap();
-    assert_eq!(stats.header_count, 75_000);
-    assert_eq!(stats.filter_header_count, 75_000);
-
     storage.shutdown().await;
 }