fix: coderabbit review fixes#104

Merged

QuantumExplorer merged 28 commits intodashpay:v0.40-devfrom

DCG-Claude:fix/cr-review-fixes

Aug 16, 2025

Commits on Aug 16, 2025

fix(dash-spv): correct NetworkMessage enum variant name from GetMnListD to GetMnListDiff

authored and
dcg
committed
fix(dash-spv): add explicit error handling to find_chain_lock_quorum function

authored and
dcg
committed
fix(dash-spv): align block message expectations with runtime behavior in MnList phase

authored and
dcg
committed
fix(dash-spv): resolve storage handle shadowing in chainlock validation test

authored and
dcg
committed
fix(dash-spv): use actual block height in MnListDiff validation errors

authored and
dcg
committed
fix(dash-spv): replace MemoryStorage with MemoryStorageManager in validation tests

authored and
dcg
committed
fix(dash-spv): correct test assertion for qr_info_extra_share default

authored and
dcg
committed
fix(dash-spv): add bounds checking to sync phase completion methods

authored and
dcg
committed
fix(sml): use per-window mining_start for LLMQ type skip check

authored and
dcg
committed
fix(docs): update API documentation to match actual dash-spv implementation

authored and
dcg
committed
fix(dash-spv): replace hardcoded quorum size with dynamic LLMQ size

authored and
dcg
committed
fix(dash-spv): update MockStorageManager to match current StorageManager trait

authored and
dcg
committed
Replace todo!() with real QRInfo response correlation implementation

authored and
dcg
committed
fix(phase-3): correct processing_time to store elapsed duration instead of instant

authored and
dcg
committed
Replace todo!() with real QRInfo response correlation implementation

authored and
dcg
committed
fix(qr_info_spv_plan): replace send_error with proper Result type handling

authored and
dcg
committed
fix(qr_info_spv_plan): replace trait object Vec with enum-based recovery strategies

authored and
dcg
committed
Fix QRInfoCorrelationManager pending_requests field synchronization

authored and
dcg
committed
fix: integrate Phase 3 with existing dash-spv interfaces instead of duplicating

authored and
dcg
committed
fix(dash-spv): correct NetworkMessage enum variant to GetMnListD

dcg
authored and
dcg
committed
fix(build): resolve compilation errors in key-wallet-ffi and dash-spv

dcg
authored and
dcg
committed
revert: undo extra changes to dash-spv/src/sync/sequential/mod.rs from commit 6be28eb8

dcg
authored and
dcg
committed
revert: restore KeyWalletFFI targets in Package.swift from commit 5786b788

dcg
authored and
dcg
committed
chore: remove qr_info_spv_plan folder

dcg
authored and
dcg
committed
revert: uncomment AddressGenerator interface in key_wallet.udl

dcg
authored and
dcg
committed
revert: restore original key-wallet-ffi/src/lib.rs implementation

dcg
authored and
dcg
committed
fix: restore working versions from v0.40-dev to fix build and test compilation

authored and
dcg
committed
fix: add missing UnconfirmedTransaction import in error_handling_test.rs

authored and
dcg
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: coderabbit review fixes#104

fix: coderabbit review fixes#104
QuantumExplorer merged 28 commits intodashpay:v0.40-devfrom
DCG-Claude:fix/cr-review-fixes

Commits on Aug 16, 2025

fix(dash-spv): correct NetworkMessage enum variant name from GetMnListD to GetMnListDiff

fix(dash-spv): add explicit error handling to find_chain_lock_quorum function

fix(dash-spv): align block message expectations with runtime behavior in MnList phase

fix(dash-spv): resolve storage handle shadowing in chainlock validation test

fix(dash-spv): use actual block height in MnListDiff validation errors

fix(dash-spv): replace MemoryStorage with MemoryStorageManager in validation tests

fix(dash-spv): correct test assertion for qr_info_extra_share default

fix(dash-spv): add bounds checking to sync phase completion methods

fix(sml): use per-window mining_start for LLMQ type skip check

fix(docs): update API documentation to match actual dash-spv implementation

fix(dash-spv): replace hardcoded quorum size with dynamic LLMQ size

fix(dash-spv): update MockStorageManager to match current StorageManager trait

Replace todo!() with real QRInfo response correlation implementation

fix(phase-3): correct processing_time to store elapsed duration instead of instant

Replace todo!() with real QRInfo response correlation implementation

fix(qr_info_spv_plan): replace send_error with proper Result type handling

fix(qr_info_spv_plan): replace trait object Vec with enum-based recovery strategies

Fix QRInfoCorrelationManager pending_requests field synchronization

fix: integrate Phase 3 with existing dash-spv interfaces instead of duplicating

fix(dash-spv): correct NetworkMessage enum variant to GetMnListD

fix(build): resolve compilation errors in key-wallet-ffi and dash-spv

revert: undo extra changes to dash-spv/src/sync/sequential/mod.rs from commit 6be28eb8

revert: restore KeyWalletFFI targets in Package.swift from commit 5786b788

chore: remove qr_info_spv_plan folder

revert: uncomment AddressGenerator interface in key_wallet.udl

revert: restore original key-wallet-ffi/src/lib.rs implementation

fix: restore working versions from v0.40-dev to fix build and test compilation

fix: add missing UnconfirmedTransaction import in error_handling_test.rs