feat: build out key-wallet ffi and improve ci

.github/strict-checks.json

@@ -0,0 +1,22 @@
+{
+  "strict_check_crates": [
+    "key-wallet",
+    "key-wallet-manager",
+    "key-wallet-ffi"
+  ],
+  "excluded_crates": [
+    "dash",
+    "dash-network",
+    "dash-network-ffi",
+    "hashes",
+    "internals",
+    "fuzz",
+    "rpc-client",
+    "rpc-json",
+    "rpc-integration-test",
+    "dash-spv",
+    "dash-spv-ffi",
+    "test-utils"
+  ],
+  "comment": "Crates in strict_check_crates will fail CI on any warnings or clippy issues. Add or remove crates as needed."
+}

.github/workflows/fuzz.yml

@@ -8,6 +8,13 @@ on:
       - 'test-ci/**'
   pull_request:
 
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   fuzz:
     if: ${{ !github.event.act }}
@@ -40,19 +47,14 @@ jobs:
       - name: Install test dependencies
         run: sudo apt-get update -y && sudo apt-get install -y binutils-dev libunwind8-dev libcurl4-openssl-dev libelf-dev libdw-dev cmake gcc libiberty-dev
       - uses: actions/checkout@v4
-      - uses: actions/cache@v4
-        id: cache-fuzz
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
         with:
-          path: |
-            ~/.cargo/bin
-            fuzz/target
-            target
-          key: cache-${{ matrix.target }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
-      - uses: actions-rs/toolchain@v1
+          toolchain: 1.89
+      - name: Cache cargo dependencies
+        uses: Swatinem/rust-cache@v2
         with:
-          toolchain: 1.85
-          override: true
-          profile: minimal
+          workspaces: "fuzz -> target"
       - name: fuzz
         run: cd fuzz && ./fuzz.sh "${{ matrix.fuzz_target }}"
       - run: echo "${{ matrix.fuzz_target }}" >executed_${{ matrix.fuzz_target }}

.github/workflows/rust.yml

@@ -2,6 +2,13 @@ on: [push, pull_request]
 
 name: Continuous integration
 
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   Tests:
     name: Tests
@@ -26,21 +33,130 @@ jobs:
               AS_DEPENDENCY: true
               DO_NO_STD: false
               DO_DOCS: true
-          - rust: 1.85.0
+          - rust: 1.89.0
             env:
               AS_DEPENDENCY: true
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
-      - name: Checkout Toolchain
-        uses: actions-rs/toolchain@v1
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
         with:
-          profile: minimal
           toolchain: ${{ matrix.rust }}
-          override: true
       - name: Running test script
         env: ${{ matrix.env }}
         run: ./contrib/test.sh
+
+  workspace-tests:
+    name: Workspace Tests
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        rust: [stable, beta, nightly, 1.89.0]
+    steps:
+      - name: Checkout Crate
+        uses: actions/checkout@v4
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: ${{ matrix.rust }}
+      - name: Cache cargo dependencies
+        uses: Swatinem/rust-cache@v2
+      - name: Run workspace tests
+        run: cargo test --workspace --all-features
+      - name: Run workspace tests (no default features)
+        run: cargo test --workspace --no-default-features
+      - name: Build workspace (release mode)
+        run: cargo build --workspace --release
+
+  clippy:
+    name: Clippy (Non-strict)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Crate
+        uses: actions/checkout@v4
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: stable
+          components: clippy
+      - name: Run clippy (excluding strict-checked crates)
+        run: |
+          # Auto-discover all workspace crates and exclude strict-checked ones
+          STRICT_CRATES=("key-wallet" "key-wallet-manager" "key-wallet-ffi")
+          mapfile -t ALL_CRATES < <(cargo metadata --no-deps --format-version=1 | jq -r '.packages[].name' | sort -u)
+          for crate in "${ALL_CRATES[@]}"; do
+            if printf '%s\n' "${STRICT_CRATES[@]}" | grep -qx "$crate"; then
+              continue
+            fi
+            echo "Checking $crate (warnings allowed)..."
+            cargo clippy -p "$crate" --all-features --all-targets || true
+          done
+
+  strict-checks:
+    name: Strict Warnings and Clippy Checks
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Crate
+        uses: actions/checkout@v4
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: stable
+          components: clippy
+      - name: Cache cargo dependencies
+        uses: Swatinem/rust-cache@v2
+
+      # Check key-wallet with strict warnings
+      - name: Check key-wallet (deny warnings)
+        env:
+          RUSTFLAGS: "-D warnings"
+        run: |
+          cargo check -p key-wallet --all-features --lib --bins --tests
+          cargo build -p key-wallet --all-features --lib --bins
+          cargo test -p key-wallet --all-features --lib --bins
+
+      - name: Clippy key-wallet (deny all warnings)
+        run: cargo clippy -p key-wallet --all-features --lib --bins --tests -- -D warnings
+
+      # Check key-wallet-manager with strict warnings
+      - name: Check key-wallet-manager (deny warnings)
+        env:
+          RUSTFLAGS: "-D warnings"
+        run: |
+          cargo check -p key-wallet-manager --all-features --lib --bins --tests
+          cargo build -p key-wallet-manager --all-features --lib --bins
+          cargo test -p key-wallet-manager --all-features --lib --bins
+
+      - name: Clippy key-wallet-manager (deny all warnings)
+        run: cargo clippy -p key-wallet-manager --all-features --lib --bins --tests -- -D warnings
+
+      # Check key-wallet-ffi with strict warnings
+      - name: Check key-wallet-ffi (deny warnings)
+        env:
+          RUSTFLAGS: "-D warnings"
+        run: |
+          cargo check -p key-wallet-ffi --all-features --lib --bins --tests
+          cargo build -p key-wallet-ffi --all-features --lib --bins
+          cargo test -p key-wallet-ffi --all-features --lib --bins
+
+      - name: Clippy key-wallet-ffi (deny all warnings)
+        run: cargo clippy -p key-wallet-ffi --all-features --lib --bins --tests -- -D warnings
+
+  fmt:
+    name: Format
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Crate
+        uses: actions/checkout@v4
+      - name: Setup Rust toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: stable
+          components: rustfmt
+      - name: Check formatting
+        run: cargo fmt --all -- --check
 
 # TODO: need to support compiling rust-x11-hash under s390x
 #  Cross:
@@ -49,9 +165,9 @@ jobs:
 #    runs-on: ubuntu-latest
 #    steps:
 #      - name: Checkout Crate
-#        uses: actions/checkout@v2
+#        uses: actions/checkout@v4
 #      - name: Checkout Toolchain
-#        uses: actions-rs/toolchain@v1
+#        uses: dtolnay/rust-toolchain@stable
 #        with:
 #          profile: minimal
 #          toolchain: stable
@@ -88,7 +204,7 @@ jobs:
 #        run: cd hashes/embedded && cargo run --target thumbv7m-none-eabi --features=alloc
 
     rpc-tests:
-      name: Tests
+      name: RPC Tests
       runs-on: ubuntu-latest
       strategy:
         matrix:
@@ -99,18 +215,16 @@ jobs:
             - rust: nightly
               env:
                 RUSTFMTCHK: false
-            - rust: 1.85.0
+            - rust: 1.89.0
               env:
                 PIN_VERSIONS: true
       steps:
         - name: Checkout Crate
-          uses: actions/checkout@v2
-        - name: Checkout Toolchain
-          uses: actions-rs/toolchain@v1
+          uses: actions/checkout@v4
+        - name: Setup Rust toolchain
+          uses: dtolnay/rust-toolchain@stable
           with:
-            profile: minimal
             toolchain: ${{ matrix.rust }}
-            override: true
         - name: Running test script
           env: ${{ matrix.env }}
           run: ./contrib/test.sh
@@ -133,13 +247,11 @@ jobs:
             ]
       steps:
         - name: Checkout Crate
-          uses: actions/checkout@v2
-        - name: Checkout Toolchain
-          uses: actions-rs/toolchain@v1
+          uses: actions/checkout@v4
+        - name: Setup Rust toolchain
+          uses: dtolnay/rust-toolchain@stable
           with:
-            profile: minimal
             toolchain: ${{ matrix.rust }}
-            override: true
         - name: Running test script
           env:
             BITCOINVERSION: ${{ matrix.bitcoinversion }}

CLAUDE.md

@@ -24,13 +24,13 @@ rust-dashcore is a Rust implementation of the Dash cryptocurrency protocol libra
 
 ### Network & SPV
 - `dash-network/` - Network protocol abstractions
-- `dash-network-ffi/` - Network FFI bindings using UniFFI
+- `dash-network-ffi/` - C-compatible FFI bindings for network types
 - `dash-spv/` - SPV client implementation
 - `dash-spv-ffi/` - C-compatible FFI bindings for SPV client
 
 ### Wallet & Keys
 - `key-wallet/` - HD wallet implementation
-- `key-wallet-ffi/` - FFI bindings for wallet functionality
+- `key-wallet-ffi/` - C-compatible FFI bindings for wallet functionality
 
 ### RPC & Integration
 - `rpc-client/` - JSON-RPC client for Dash Core nodes

dash-network-ffi/Cargo.toml

@@ -11,19 +11,12 @@ readme = "README.md"
 
 [dependencies]
 dash-network = { path = "../dash-network", default-features = false }
-uniffi = { version = "0.29.3", features = ["cli"] }
 thiserror = "2.0.12"
 
-[build-dependencies]
-uniffi = { version = "0.29.3", features = ["build"] }
-
 [dev-dependencies]
 hex = "0.4"
 
 [lib]
 crate-type = ["cdylib", "staticlib"]
 name = "dash_network_ffi"
 
-[[bin]]
-name = "uniffi-bindgen"
-path = "uniffi-bindgen.rs"

dash-network-ffi/README.md

@@ -1,14 +1,14 @@
 # dash-network-ffi
 
-FFI bindings for the dash-network crate, providing language bindings via UniFFI.
+FFI bindings for the dash-network crate, providing C-compatible language bindings.
 
 ## Overview
 
 This crate provides Foreign Function Interface (FFI) bindings for the `dash-network` types, allowing them to be used from other programming languages like Swift, Python, Kotlin, and Ruby.
 
 ## Features
 
-- UniFFI-based bindings for the Network enum
+- C-compatible FFI bindings for the Network enum
 - Network information and utilities exposed through FFI
 - Support for magic bytes operations
 - Core version activation queries
@@ -21,16 +21,6 @@ This crate provides Foreign Function Interface (FFI) bindings for the `dash-netw
 cargo build --release
 ```
 
-### Generating Bindings
-
-To generate bindings for your target language:
-
-```bash
-cargo run --bin uniffi-bindgen generate src/dash_network.udl --language swift
-cargo run --bin uniffi-bindgen generate src/dash_network.udl --language python
-cargo run --bin uniffi-bindgen generate src/dash_network.udl --language kotlin
-```
-
 ### Example Usage (Swift)
 
 ```swift

dash-network-ffi/build.rs

@@ -1,3 +1,4 @@
 fn main() {
-    uniffi::generate_scaffolding("src/dash_network.udl").unwrap();
+    // Build script for dash-network-ffi
+    // Standard FFI compilation without uniffi
 }