Merged
Conversation
Contributor
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 130 files out of 237 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
56190e2 to
8bcd6db
Compare
QuantumExplorer
approved these changes
Dec 1, 2025
pauldelucia
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Add pre-commit infrastructure * Remove all steps in `rust.yml` which are now covered by `pre-commit` * Fix `trailing-whitespace` checks * Fix `end-of-file-fixer` checks * Fix `check-executables-have-shebangs` checks * Fix `check-shebang-scripts-are-executable` checks * Fix actionlint * Fix `typos` checks * Fix `clippy-workspace` checks * Fix `verify-ffi-docs` * Revert intentional typo fix for testing * Remove the redundant format/linting section in `CONTRIBUTING.md` * Change `id` from `clippy-workspace` to `clippy` * Fix `verify FFI` stage
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 26, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Properly keep track of all create wallets and wallet infos and clean them up at the end. - Head allocate wallet infos like it would happen in real FFI usage and free them properly at the end.
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 26, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Modified `set_error`, `set_success`, and `ffi_error_set` macro to free previous error messages before setting new ones - Added `FFIError::free_message` helper for test cleanup - Added cleanup in all relevalt tests
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 26, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Properly keep track of all create wallets and wallet infos and clean them up at the end. - Head allocate wallet infos like it would happen in real FFI usage and free them properly at the end.
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 26, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Modified `set_error`, `set_success`, and `ffi_error_set` macro to free previous error messages before setting new ones - Added `FFIError::free_message` helper for test cleanup - Added cleanup in all relevalt tests
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Properly keep track of all create wallets and wallet infos and clean them up at the end. - Head allocate wallet infos like it would happen in real FFI usage and free them properly at the end.
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Modified `set_error`, `set_success`, and `ffi_error_set` macro to free previous error messages before setting new ones - Added `FFIError::free_message` helper for test cleanup - Added cleanup in all relevalt tests
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Properly keep track of all create wallets and wallet infos and clean them up at the end. - Head allocate wallet infos like it would happen in real FFI usage and free them properly at the end.
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Modified `set_error`, `set_success`, and `ffi_error_set` macro to free previous error messages before setting new ones - Added `FFIError::free_message` helper for test cleanup - Added cleanup in all relevalt tests
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Properly keep track of all create wallets and wallet infos and clean them up at the end. - Head allocate wallet infos like it would happen in real FFI usage and free them properly at the end.
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Dec 27, 2025
This fixes a bunch of memory leaks in tests detected by sanitizer in CI overhaul PR dashpay#201. - Modified `set_error`, `set_success`, and `ffi_error_set` macro to free previous error messages before setting new ones - Added `FFIError::free_message` helper for test cleanup - Added cleanup in all relevalt tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds https://pre-commit.com to the project which is a framework that runs automated checks on your code before you commit or push to help catching issues before they hit the CI. The same checks will also run in the CI via the integrated pre-commit github workflow.
This should be reviewed commit by commit since its pretty big PR mainly because of c422499 which fixes 2000 lines of trailing whitespaces. The first commit introduces all the infrastructure, the second cleans up all the github workflow steps which are now consolidated in the pre-commit config and the other commits just fix up one pre-commit stage per commit to get all of them to pass.
With
pre commithooks installedSee https://github.com/dashpay/rust-dashcore/blob/3543d2386f1385d1cf62d1fcf9863c94553f1356/CONTRIBUTING.md#pre-commit-hooks
When commiting:
When pushing:
If something fails, the commit/push is blocked and you'll see what needs fixing while most things get auto generated via the check run.