feat(spv): reverse quorum hash lookup function#216
Closed
pauldelucia wants to merge 8 commits intov0.41-devfrom
Closed
feat(spv): reverse quorum hash lookup function#216pauldelucia wants to merge 8 commits intov0.41-devfrom
pauldelucia wants to merge 8 commits intov0.41-devfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2340750 to
c586be9
Compare
xdustinface
requested changes
Nov 27, 2025
Collaborator
xdustinface
left a comment
There was a problem hiding this comment.
This seems more like a client specific thing. Shouldn't this be done in DET rather since SPV follows and matches core?
994f45d to
1d765dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAPI returns quorum hash in big endian in its
ResponseMetadatathat comes with query and state transition proofs, and in SPV we store quorum hashes in little endian. So if we want a client like DET to simply take the hash from DAPI and pass it to SPV, we need to reverse it before lookup.