Skip to content

fix: emit FiltersSyncComplete for incremental updates #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 1 commit into from
Feb 17, 2026
Merged

fix: emit FiltersSyncComplete for incremental updates #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions dash-spv/src/sync/filters/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,14 +416,17 @@ impl<H: BlockHeaderStorage, FH: FilterHeaderStorage, F: FilterStorage, W: Wallet
// Phase 3: Create lookahead batches up to MAX_LOOKAHEAD_BATCHES
events.extend(self.try_create_lookahead_batches().await?);

// If no active batches and all filters downloaded, check if we can transition to Synced
// Only emit SyncComplete if we've also reached the chain tip (target_height)
// If no active batches and all filters downloaded, emit FiltersSyncComplete.
// This handles both initial sync (Syncing → Synced transition) and incremental
// updates (already Synced, signal BlocksManager that no more blocks are coming).
if self.active_batches.is_empty()
&& self.state() == SyncState::Syncing
&& matches!(self.state(), SyncState::Syncing | SyncState::Synced)
&& self.progress.current_height() >= self.progress.filter_header_tip_height()
&& self.progress.current_height() >= self.progress.target_height()
{
self.set_state(SyncState::Synced);
if self.state() == SyncState::Syncing {
self.set_state(SyncState::Synced);
}
tracing::info!("Filter sync complete at height {}", self.progress.current_height());
events.push(SyncEvent::FiltersSyncComplete {
tip_height: self.progress.current_height(),
Expand Down
Loading