chore: updated packages and change to rust edition 2024

[QuantumExplorer]

Summary by CodeRabbit

• Chores

  • Upgraded several dependency versions and replaced deprecated packages for improved maintainability.
  • Removed unused imports and legacy code to streamline internal configuration.
  • Updated Rust edition to 2024 across multiple packages for enhanced language features.

• Tests

  • Simplified serialization tests by focusing on JSON and removing obsolete binary serialization checks.
  • Renamed and removed redundant test functions to modernize the test suite and align with current practices.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates dependency versions in the project’s Cargo manifests, refines test files by removing unused imports and binary serialization checks, and adjusts serialization for the U256 struct by incorporating bincode’s encoding and decoding traits. Additionally, an entire test suite regarding serde regression has been removed. Overall, the changes simplify certain tests and improve the clarity and efficiency of binary serialization operations within the codebase.

Changes

File(s)	Change Summary
dash/Cargo.toml	Updated versions for dependencies (bech32, core2, rustversion, actual-serde, bitflags, blake3, thiserror) and dev-dependencies (serde_json, serde_test, serde_derive); replaced bincode_test with bincode =2.0.0-rc.3.
dash/src/blockdata/script/tests.rs, dash/src/blockdata/witness.rs, dash/src/crypto/sighash.rs, dash/src/network/message_qrinfo.rs, dash/src/sml/masternode_list_engine/mod.rs, dash/src/sml/quorum_entry/quorum_modifier_type.rs	Removed redundant imports and binary serialization test assertions; renamed test function to focus solely on human-readable JSON serialization.
dash/src/pow.rs	Enhanced U256 struct by adding Encode and Decode traits; updated test cases to use bincode::encode_to_vec and bincode::decode_from_slice for binary serialization.
dash/tests/serde.rs	Deleted the comprehensive serde regression test suite covering multiple data structures.

Sequence Diagram(s)

sequenceDiagram
    participant T as Test
    participant U as U256
    participant B as bincode

    T->>U: Create U256 instance
    T->>B: Call encode_to_vec(instance)
    B-->>T: Return binary data
    T->>B: Call decode_from_slice(binary data)
    B-->>T: Return decoded U256 instance

Loading

Poem

I'm a rabbit hopping through this code,
With new traits added and tests now owed,
Dependencies updated with each little leap,
Unused imports and bincode tests now asleep.
With whiskers twitching in tech delight,
I celebrate these changes day and night! 🐇

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a70f01 and f01a96d.

📒 Files selected for processing (125)

• .github/workflows/fuzz.yml (2 hunks)
• .github/workflows/rust.yml (2 hunks)
• dash/Cargo.toml (2 hunks)
• dash/embedded/Cargo.toml (1 hunks)
• dash/examples/bip32.rs (1 hunks)
• dash/examples/handshake.rs (2 hunks)
• dash/examples/taproot-psbt.rs (1 hunks)
• dash/src/address.rs (2 hunks)
• dash/src/amount.rs (2 hunks)
• dash/src/base58.rs (2 hunks)
• dash/src/bip152.rs (2 hunks)
• dash/src/bip158.rs (5 hunks)
• dash/src/bip32.rs (1 hunks)
• dash/src/blockdata/block.rs (2 hunks)
• dash/src/blockdata/constants.rs (2 hunks)
• dash/src/blockdata/fee_rate.rs (1 hunks)
• dash/src/blockdata/script/borrowed.rs (1 hunks)
• dash/src/blockdata/script/builder.rs (1 hunks)
• dash/src/blockdata/script/instruction.rs (1 hunks)
• dash/src/blockdata/script/mod.rs (1 hunks)
• dash/src/blockdata/script/owned.rs (1 hunks)
• dash/src/blockdata/script/tests.rs (3 hunks)
• dash/src/blockdata/transaction/hash_type.rs (1 hunks)
• dash/src/blockdata/transaction/mod.rs (4 hunks)
• dash/src/blockdata/transaction/outpoint.rs (2 hunks)
• dash/src/blockdata/transaction/special_transaction/asset_lock.rs (1 hunks)
• dash/src/blockdata/transaction/special_transaction/asset_unlock/qualified_asset_unlock.rs (2 hunks)
• dash/src/blockdata/transaction/special_transaction/asset_unlock/request_info.rs (1 hunks)
• dash/src/blockdata/transaction/special_transaction/asset_unlock/unqualified_asset_unlock.rs (1 hunks)
• dash/src/blockdata/transaction/special_transaction/coinbase.rs (1 hunks)
• dash/src/blockdata/transaction/special_transaction/mod.rs (1 hunks)
• dash/src/blockdata/transaction/special_transaction/provider_registration.rs (3 hunks)
• dash/src/blockdata/transaction/special_transaction/provider_update_registrar.rs (2 hunks)
• dash/src/blockdata/transaction/special_transaction/provider_update_revocation.rs (2 hunks)
• dash/src/blockdata/transaction/special_transaction/provider_update_service.rs (2 hunks)
• dash/src/blockdata/transaction/special_transaction/quorum_commitment.rs (2 hunks)
• dash/src/blockdata/transaction/txin.rs (1 hunks)
• dash/src/blockdata/witness.rs (2 hunks)
• dash/src/consensus/encode.rs (7 hunks)
• dash/src/consensus/mod.rs (1 hunks)
• dash/src/consensus/params.rs (1 hunks)
• dash/src/consensus/serde.rs (1 hunks)
• dash/src/crypto/key.rs (3 hunks)
• dash/src/crypto/sighash.rs (2 hunks)
• dash/src/dip9.rs (1 hunks)
• dash/src/ephemerealdata/chain_lock.rs (1 hunks)
• dash/src/ephemerealdata/instant_lock.rs (1 hunks)
• dash/src/hash_types.rs (1 hunks)
• dash/src/internal_macros.rs (1 hunks)
• dash/src/merkle_tree/block.rs (2 hunks)
• dash/src/network/constants.rs (1 hunks)
• dash/src/network/message.rs (1 hunks)
• dash/src/network/message_bloom.rs (1 hunks)
• dash/src/network/message_network.rs (1 hunks)
• dash/src/network/message_qrinfo.rs (1 hunks)
• dash/src/pow.rs (4 hunks)
• dash/src/psbt/map/global.rs (1 hunks)
• dash/src/psbt/map/input.rs (1 hunks)
• dash/src/psbt/map/output.rs (1 hunks)
• dash/src/psbt/mod.rs (5 hunks)
• dash/src/psbt/raw.rs (1 hunks)
• dash/src/psbt/serialize.rs (1 hunks)
• dash/src/sign_message.rs (1 hunks)
• dash/src/signer.rs (2 hunks)
• dash/src/sml/address.rs (1 hunks)
• dash/src/sml/llmq_entry_verification.rs (1 hunks)
• dash/src/sml/llmq_type/mod.rs (1 hunks)
• dash/src/sml/llmq_type/network.rs (1 hunks)
• dash/src/sml/masternode_list/masternode_helpers.rs (1 hunks)
• dash/src/sml/masternode_list/merkle_roots.rs (1 hunks)
• dash/src/sml/masternode_list/peer_addresses.rs (1 hunks)
• dash/src/sml/masternode_list/scores_for_quorum.rs (1 hunks)
• dash/src/sml/masternode_list_engine/message_request_verification.rs (2 hunks)
• dash/src/sml/masternode_list_engine/mod.rs (4 hunks)
• dash/src/sml/masternode_list_engine/non_rotated_quorum_construction.rs (1 hunks)
• dash/src/sml/masternode_list_engine/rotated_quorum_construction.rs (1 hunks)
• dash/src/sml/masternode_list_engine/validation.rs (1 hunks)
• dash/src/sml/masternode_list_entry/hash.rs (1 hunks)
• dash/src/sml/masternode_list_entry/qualified_masternode_list_entry.rs (1 hunks)
• dash/src/sml/message_verification_error.rs (1 hunks)
• dash/src/sml/quorum_entry/hash.rs (1 hunks)
• dash/src/sml/quorum_entry/quorum_modifier_type.rs (1 hunks)
• dash/src/sml/quorum_entry/verify_message.rs (1 hunks)
• dash/src/sml/quorum_validation_error.rs (1 hunks)
• dash/src/taproot.rs (4 hunks)
• fuzz/Cargo.toml (1 hunks)
• fuzz/fuzz_targets/hashes/cbor.rs (1 hunks)
• fuzz/fuzz_targets/hashes/json.rs (1 hunks)
• fuzz/fuzz_targets/hashes/ripemd160.rs (1 hunks)
• fuzz/fuzz_targets/hashes/sha1.rs (1 hunks)
• fuzz/fuzz_targets/hashes/sha256.rs (1 hunks)
• fuzz/fuzz_targets/hashes/sha512.rs (1 hunks)
• fuzz/fuzz_targets/hashes/sha512_256.rs (1 hunks)
• fuzz/generate-files.sh (1 hunks)
• hashes/Cargo.toml (1 hunks)
• hashes/embedded/Cargo.toml (1 hunks)
• hashes/extended_tests/schemars/Cargo.toml (1 hunks)
• hashes/src/bincode_macros.rs (1 hunks)
• hashes/src/cmp.rs (1 hunks)
• hashes/src/error.rs (1 hunks)
• hashes/src/hash160.rs (4 hunks)
• hashes/src/hash_x11.rs (1 hunks)
• hashes/src/hmac.rs (3 hunks)
• hashes/src/impls.rs (2 hunks)
• hashes/src/lib.rs (1 hunks)
• hashes/src/ripemd160.rs (3 hunks)
• hashes/src/serde_macros.rs (1 hunks)
• hashes/src/sha1.rs (4 hunks)
• hashes/src/sha256.rs (4 hunks)
• hashes/src/sha256d.rs (4 hunks)
• hashes/src/sha256t.rs (1 hunks)
• hashes/src/sha512.rs (3 hunks)
• hashes/src/sha512_256.rs (3 hunks)
• hashes/src/siphash24.rs (2 hunks)
• hashes/src/util.rs (2 hunks)
• internals/Cargo.toml (1 hunks)
• internals/src/hex/display.rs (1 hunks)
• rpc-client/Cargo.toml (1 hunks)
• rpc-client/examples/test_against_node.rs (1 hunks)
• rpc-client/src/client.rs (2 hunks)
• rpc-integration-test/Cargo.toml (1 hunks)
• rpc-integration-test/src/main.rs (2 hunks)
• rpc-json/Cargo.toml (1 hunks)
• rpc-json/src/lib.rs (3 hunks)
• rustfmt.toml (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[QuantumExplorer]

Still having issues with Fuzz tests, they should go away when we upgrade bincode.