fix(json-rpc): change value sat from u32 to u64

[pauldelucia]

In GetRawTransactionResultVin and GetRawTransactionResultVout, value_sat should be u64.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of large satoshi values in transaction details to ensure accurate display for higher amounts.

[coderabbitai]

Walkthrough

The changes modify the data types of the value_sat fields in two structs within the rpc-json/src/lib.rs file. In the GetRawTransactionResultVin struct, the value_sat field is updated from Option<u32> to Option<u64>, and in the GetRawTransactionResultVout struct, the type is changed from u32 to u64. These updates increase the range of values these fields can store, allowing for larger satoshi amounts to be represented.

Changes

File(s)	Change Summary
rpc-json/src/lib.rs	Changed value_sat field type from Option<u32> to Option<u64> in GetRawTransactionResultVin and from u32 to u64 in GetRawTransactionResultVout.

Poem

In fields of satoshis, once small and tight,
We’ve widened the gates to store values right.
From u32 to u64, the numbers now soar,
No longer constrained by the limits before.
A hop and a leap, our structs now can boast,
Of handling big coins, from least to utmost!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed45bf8 and 3d19182.

📒 Files selected for processing (1)

• rpc-json/src/lib.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_deserialize_amount)

🔇 Additional comments (2)

rpc-json/src/lib.rs (2)

543-543: Correctly update value_sat to Option<u64> for large satoshi support.

This change is necessary to support the full range of possible satoshi values. Ensure all usages and tests are updated accordingly, as this is a breaking change for consumers expecting Option<u32>.

Consider verifying that all code and tests using GetRawTransactionResultVin.value_sat are updated to handle Option<u64>, and that deserialization from JSON with large values works as expected.

---

582-582: Correctly update value_sat to u64 for large satoshi support.

This change is necessary for correctness, as satoshi values can exceed the range of u32. Ensure all usages and tests are updated accordingly, as this is a breaking change for consumers expecting u32.

Consider verifying that all code and tests using GetRawTransactionResultVout.value_sat are updated to handle u64, and that deserialization from JSON with large values works as expected.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[QuantumExplorer]

Honestly a bit weird that we have value and value sat, I'm guessing it has something to do with core rpc diverging from bitcoin.