-
Notifications
You must be signed in to change notification settings - Fork 21
Remove slf4j-simple dependency #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed slf4j-simple dependency from pom.xml. Libraries should only have a dependency on slf4j-api and not on slf4j-simple or any other specific logging binding (like logback-classic or log4j-core). This allows the application that uses your library to choose its own logging implementation, which is the main purpose of the SLF4J facade.
Summary of ChangesHello @gwttk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's dependency management by removing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the slf4j-simple dependency, which is a best practice for Java libraries to avoid forcing a specific logging implementation on consumers. This allows applications using this SDK to choose their own logging backend. I've included a suggestion to add a logging implementation back but scoped for tests, which will help with debugging during development.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Removed slf4j-simple dependency from pom.xml.
Libraries should only have a dependency on slf4j-api and not on slf4j-simple or any other specific logging binding (like logback-classic or log4j-core). This allows the application that uses your library to choose its own logging implementation, which is the main purpose of the SLF4J facade.