Add pruning default dask configs before serialization#467
Merged
jacobtomlinson merged 2 commits intodask:mainfrom Jul 7, 2025
Merged
Add pruning default dask configs before serialization#467jacobtomlinson merged 2 commits intodask:mainfrom
jacobtomlinson merged 2 commits intodask:mainfrom
Conversation
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for picking up a 4 year old issue, this is awesome.
Could I ask you to write some tests for it?
Contributor
Author
|
@jacobtomlinson I had to make some refactoring so that it could be covered with tests properly. Also, there is a caveat regarding the solution: it only works when security set to False, otherwise user data still is over limit because of serialized certificates. |
Member
|
Yeah this is a known issue. I don't think this PR actually loses #249 because most people want |
jacobtomlinson
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this solves the issue (#249). Thanks.