Skip to content

Fix for breaking change in gcp cluster "TypeError: '>' not supported between instances of 'str' and 'int'" #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for breaking change in gcp cluster "TypeError: '>' not supported between instances of 'str' and 'int'" #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dask_cloudprovider/gcp/instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,17 +662,18 @@ def __init__(
self.scheduler_machine_type = machine_type
self.worker_machine_type = machine_type

self.ngpus = ngpus or self.config.get("ngpus")
ngpus_value = ngpus or self.config.get("ngpus")
self.ngpus = int(ngpus_value) if ngpus_value else None
if not self.ngpus:
self.scheduler_ngpus = (
scheduler_ngpus
if scheduler_ngpus is not None
else self.config.get("scheduler_ngpus", 0)
else int(self.config.get("scheduler_ngpus") or 0)
)
self.worker_ngpus = (
worker_ngpus
if worker_ngpus is not None
else self.config.get("worker_ngpus", 0)
else int(self.config.get("worker_ngpus") or 0)
)
else:
if scheduler_ngpus is not None or worker_ngpus is not None:
Expand Down
Loading