Skip to content

Recommend miniforge conda installer in docs#395

Merged
m-albert merged 6 commits intodask:mainfrom
m-albert:recommend_miniforge
Apr 15, 2025
Merged

Recommend miniforge conda installer in docs#395
m-albert merged 6 commits intodask:mainfrom
m-albert:recommend_miniforge

Conversation

@m-albert
Copy link
Collaborator

Closes #394.

@m-albert
Copy link
Collaborator Author

Right, this will require merging and rebasing on #393 for getting green CI.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marvin! 🙏

This looks great 😄

With the CI PR in, updated this one to pull in the CI changes

Made some very minor tweaks below. Hope that is ok 🙂

Please let me know what you think

CONTRIBUTING.rst Outdated
Comment on lines +146 to +148
.. note::
If you do not have Anaconda/miniconda installed, please follow
`these instructions <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_.
If you don't have `conda`_ installed, we recommend downloading and installing it
with the conda-forge distribution `Miniforge here`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted the same issue in CONTRIBUTING.rst. The text looked the same as docs/installation.rst. So copied your text over here

We will use conda to
`create an environment from a file
<https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file>`_
`create an environment from a file`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted this long in text URL. Thought it would be better to extract this. So moved it below with the 2 other URLs needed for text update


If you don't have `conda`_ installed, we recommend downloading and installing it
with the conda-forge distribution `Miniforge here`_.
with the conda-forge distribution `Miniforge`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought the here could be dropped. So made this change throughout

@jakirkham
Copy link
Member

If it looks ok, please feel free to merge

Also happy to discuss as needed

@m-albert
Copy link
Collaborator Author

Thank you @jakirkham for your review and improvements here 🙏

Merging.

@m-albert m-albert merged commit 5b1bcc9 into dask:main Apr 15, 2025
17 checks passed
@jakirkham
Copy link
Member

Thanks again Marvin! 🙏

Happy to help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recommend installing conda from miniforge instead of anaconda in the docs?

2 participants