-
-
Couldn't load subscription status.
- Fork 155
Add validation check for out-of-range nodeport values #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skirui-source
wants to merge
16
commits into
dask:main
Choose a base branch
from
skirui-source:fix-nodeport-range
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e4c22c1
create new pr, initial changes
skirui-source ab5d686
switch tests order
skirui-source 91238d9
add checks for both and
skirui-source d2568a6
check if field are dict types
skirui-source 1a1cdd9
edit the loop that checks dictionary fields
skirui-source 5a2d7a7
fix failing tests
skirui-source 046d6ec
explicitly set error messaege from exception
skirui-source 61e0c0b
add validation check for node port value
skirui-source 365c37a
Merge branch 'main' of https://github.com/dask/dask-kubernetes into f…
skirui-source 67788eb
check all ports in spec
skirui-source 719347a
Update dask_kubernetes/operator/controller/controller.py
skirui-source 4911a17
add test- noeport out of range
skirui-source b62caa9
add test for valid nodeport case
skirui-source 6ba1042
minor fix, exception handling
skirui-source f42cdad
add validation hook at resource creation time
skirui-source 06e515c
confgure admission handler tunnel/server
skirui-source File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.